Added autogrow on spyed css proprties change #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evyros
reviewed
Jul 4, 2017
angularjs-autogrow.js
Outdated
| return $element.css(property); | ||
| }, | ||
| styleChangedCallBack, | ||
| true |
There was a problem hiding this comment.
@frabnt looks great.
One question though: how necessary is the 3rd parameter of 'true' for deep watching?
Can you bring an example for it?
There was a problem hiding this comment.
Just checked angular doc and it's not needed for this use case. I'm going to update the PR
|
@evyros is the PR ok? |
|
@astronati From a glimpse it looks good, I'll test it today before I release it officially. |
|
Thanks @frabnt, that's exactly what was missing. |
|
Awesome! thank you for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.