refactor(make-svg): replace ember-copy with assign #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAICT `asset.attrs` is a shallow object and does not implement the [`Copyable` interface][1] or the `copy` method. Calling the `copy` function from ember-copy on it therefore only creates a shallow copy. This is exactly what [`assign`][2] does, when you assign into an empty object. Referencing evoactivity#77. [1]: https://www.emberjs.com/api/ember/release/classes/Ember.Copyable [2]: https://emberjs.com/api/api/ember/release/functions/@ember%2Fpolyfills/assign
|
Would love to see this one in there! I have been seeing deprecations on Ember.Copyable in > 3.3. |
|
Unfortunately, it breaks compatibility with older Ember versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT
asset.attrsis a shallow object and does not implement theCopyableinterface or thecopymethod. Calling thecopyfunction from ember-copy on it therefore only creates a shallow copy.This is exactly what
assigndoes, when you assign into an empty object.Referencing #77.