upgrade cheerio to 1.0 (fixes build) #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 Should be ok if I switch to node 18 in svg-optimizer CI file ? |
sly7-7
force-pushed
the
fix-build-upgrade-cheerio
branch
from
d0f3755
to
8077718
Compare
|
I'll cut a release with this PR included tomorrow evening. Thanks for the contribution :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem build my ember app because of breaking changes between cheerio 1.0.0-rc.12 and 1.0.0 final.
I guess that
"cheerio": "^1.0.0-rc.12"tells pnpm to download 1.0.0.I don't know exactly what I'm doing in this PR, but the thing is that tests are green.