Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: empty topics shouldn't be encoded as nil #840

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Dec 14, 2021

Closes: #839

Description

Solution:

  • encode it as empty array

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: evmos#839

Solution:
- encode it as empty array
yihuang added a commit to yihuang/ethermint that referenced this pull request Dec 14, 2021
yihuang added a commit to crypto-org-chain/ethermint that referenced this pull request Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #840 (0cd047b) into main (423944b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #840   +/-   ##
=======================================
  Coverage   57.31%   57.31%           
=======================================
  Files          72       72           
  Lines        5984     5984           
=======================================
  Hits         3430     3430           
  Misses       2357     2357           
  Partials      197      197           
Impacted Files Coverage Δ
x/evm/types/logs.go 30.58% <0.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry?

@yihuang
Copy link
Contributor Author

yihuang commented Dec 14, 2021

ACK, can you add a changelog entry?

done

@fedekunze fedekunze merged commit 924232f into evmos:main Dec 14, 2021
@yihuang yihuang deleted the nil-topics branch December 16, 2021 05:30
yihuang added a commit to yihuang/ethermint that referenced this pull request Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: empty topics shouldn't be encoded as nil
2 participants