Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: need to add JSON-RPC endpoint personal_initializeWallet #740

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

adu-web3
Copy link
Contributor

@adu-web3 adu-web3 commented Nov 10, 2021

Closes #738

  • this is aimed at smartcard wallet which is not supported yet.

Description

  • this is aimed at smartcard wallet which is not supported yet.
  • an error with unsupported message will be returned for now.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes evmos#738

* this is aimed at smartcard wallet which is not supported yet.
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment. Can you add a changelog entry?

tests/rpc/personal_test.go Outdated Show resolved Hide resolved
tests/rpc/personal_test.go Outdated Show resolved Hide resolved
@fedekunze
Copy link
Contributor

@Muggle-Du can you fix the rpc tests?

=== RUN   TestPersonal_Unpair
    personal_test.go:150: 
        	Error Trace:	personal_test.go:150
        	Error:      	Should be true
        	Test:       	TestPersonal_Unpair
--- FAIL: TestPersonal_Unpair (1.00s)
=== RUN   TestPersonal_InitializeWallet
    personal_test.go:155: 
        	Error Trace:	personal_test.go:155
        	Error:      	Should be true
        	Test:       	TestPersonal_InitializeWallet
--- FAIL: TestPersonal_InitializeWallet (1.00s)

@adu-web3
Copy link
Contributor Author

adu-web3 commented Nov 10, 2021

@Muggle-Du can you fix the rpc tests?

=== RUN   TestPersonal_Unpair
    personal_test.go:150: 
        	Error Trace:	personal_test.go:150
        	Error:      	Should be true
        	Test:       	TestPersonal_Unpair
--- FAIL: TestPersonal_Unpair (1.00s)
=== RUN   TestPersonal_InitializeWallet
    personal_test.go:155: 
        	Error Trace:	personal_test.go:155
        	Error:      	Should be true
        	Test:       	TestPersonal_InitializeWallet
--- FAIL: TestPersonal_InitializeWallet (1.00s)

ok, I'll check and fix
Now all testcases including the added ones can pass @fedekunze

tests/rpc/personal_test.go Outdated Show resolved Hide resolved
tests/rpc/personal_test.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) November 11, 2021 15:10
@fedekunze fedekunze merged commit a874c1e into evmos:main Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: need to add JSON-RPC endpoint personal_initializeWallet
2 participants