This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Problem: cli keyring-backend not working correctly (fix #724) #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leejw51crypto
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 56.56% 56.58% +0.01%
==========================================
Files 64 64
Lines 5776 5774 -2
==========================================
Hits 3267 3267
+ Misses 2309 2307 -2
Partials 200 200
|
leejw51crypto
force-pushed
the
feature/724
branch
from
aa759f0
to
ca705eb
Compare
|
This pull request introduces 1 alert when merging ca705eb967b521c6a6294a42c1b5426a5c1dd4bc into d82b5c2 - view on LGTM.com new alerts:
|
leejw51crypto
force-pushed
the
feature/724
branch
2 times, most recently
from
3ed0f52
to
2a04f2b
Compare
fedekunze
reviewed
Nov 8, 2021
fedekunze
reviewed
Nov 8, 2021
|
@leejw51crypto bump |
|
i'll rebase and add to changelog |
leejw51crypto
force-pushed
the
feature/724
branch
2 times, most recently
from
1393d5d
to
31721da
Compare
…evmos#724) refactoring fix lint refactoring Apply suggestions from code review add changelog
leejw51crypto
force-pushed
the
feature/724
branch
from
31721da
to
61d9c37
Compare
|
done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in adding key,
config/client.toml backend is not used