Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

tests: networking configuration fixed #706

Merged
merged 1 commit into from
Oct 28, 2021
Merged

tests: networking configuration fixed #706

merged 1 commit into from
Oct 28, 2021

Conversation

hanchon
Copy link
Contributor

@hanchon hanchon commented Oct 27, 2021

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions github-actions bot added the Type: Tests issues and PR related to tests label Oct 27, 2021
fedekunze
fedekunze approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! thanks @hanchon! 💯

@fedekunze fedekunze merged commit b4e3d1a into fedekunze/e2e-tests Oct 28, 2021
@fedekunze fedekunze deleted the guille/e2e-tests branch October 28, 2021 11:50
fedekunze added a commit that referenced this pull request Nov 14, 2021
@fedekunze @hanchon @crypto-facs
tests: integration tests with JSON-RPC client (#704)
32c905a 
* tests: integration tests with JSON-RPC client

* fix package

* tests: networking configuration fixed (#706)

* update testnet hdPath, fixes #688

* lint

* header

* e2e wip

* fix getBlock response

* enable personal API

* changelog

Co-authored-by: Guillermo Paoletti <guillermo.paoletti@gmail.com>
Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
Type: Tests issues and PR related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanchon @fedekunze