Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: handle file close logic #679

Merged
merged 5 commits into from
Oct 19, 2021
Merged

Problem: handle file close logic #679

merged 5 commits into from
Oct 19, 2021

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Oct 15, 2021

Closes: #635

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@JayT106 JayT106 changed the title handle file close logic Problem: handle file close logic Oct 15, 2021
fedekunze
fedekunze approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending changelog entry

@fedekunze fedekunze enabled auto-merge (squash) October 19, 2021 08:52
@fedekunze fedekunze merged commit c644dd6 into evmos:main Oct 19, 2021
fedekunze added a commit that referenced this pull request Oct 22, 2021
@JayT106 @fedekunze
fix: handle file close logic (#679)
d7d5141 
* handle file close logic

* Update rpc/ethereum/namespaces/debug/utils.go

* update changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@fedekunze fedekunze mentioned this pull request Oct 22, 2021
Merged
fedekunze added a commit that referenced this pull request Oct 24, 2021
@fedekunze @tomtau
@dependabot @JayT106
release: cherry-pick v0.7.2 (#696)
39c49c6 
* changelog

* go.mod

* fix: handle file close logic (#679)

* handle file close logic

* Update rpc/ethereum/namespaces/debug/utils.go

* update changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* remove unused var (#680)

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* c++

* fix

* tendermint

* c++

* don't use IBC v2

* fix

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JayT106 <JayT106@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled errors when closing files
2 participants
@JayT106 @fedekunze