Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

chaneg log index to the index in block #354

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 26, 2021

Closes #334

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #354 (d0509a7) into main (2828fa1) will increase coverage by 0.13%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   52.47%   52.60%   +0.13%     
==========================================
  Files          46       46              
  Lines        4606     4619      +13     
==========================================
+ Hits         2417     2430      +13     
  Misses       2089     2089              
  Partials      100      100              
Impacted Files Coverage Δ
x/evm/types/key.go 0.00% <ø> (ø)
x/evm/types/logs.go 36.47% <0.00%> (-0.44%) ⬇️
x/evm/keeper/keeper.go 69.46% <100.00%> (+2.79%) ⬆️
x/evm/keeper/statedb.go 84.65% <100.00%> (+0.03%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean PR. thanks!

@fedekunze fedekunze merged commit 5458126 into evmos:main Jul 26, 2021
@yihuang yihuang deleted the logindex branch July 26, 2021 08:46
mmsqe pushed a commit to mmsqe/ethermint that referenced this pull request Sep 22, 2023
Solution:
- remove the replacement and upgrade to 0.8.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logIndex should be set to the index in the block rather than tx
2 participants