-
Notifications
You must be signed in to change notification settings - Fork 577
Conversation
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 47.38% 52.42% +5.04%
==========================================
Files 46 46
Lines 4611 4614 +3
==========================================
+ Hits 2185 2419 +234
+ Misses 2348 2093 -255
- Partials 78 102 +24
|
One of the test cases currently fail for estimated gas number different from the one returned by geth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, one minor suggestion
7cf3532
to
8396077
Compare
the test case failure is due to unclean context, now added capability for test suite to commit and begin a new block. |
927ef00
to
dba5786
Compare
Also add some test environment setup, Closes #323 test estimateGas of erc20 token transfer fix failed test case the trick is to keep a clean transient store, by doing a commit put artifacts to external file
can you fix the failing test? Then we can merge this PR |
that one is already fixed, current failure seems caused by something else, I'm checking it now. |
fixed now, remove the commit in test suite setup. |
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)