This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
ENG 119 restructure json rpc api #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Client, Ctx, getBlockNumber, getTransactionByBlockAndIndex, doCall
Codecov Report
@@ Coverage Diff @@
## main #1218 +/- ##
==========================================
- Coverage 57.20% 51.92% -5.28%
==========================================
Files 94 102 +8
Lines 8424 9282 +858
==========================================
+ Hits 4819 4820 +1
- Misses 3358 4214 +856
- Partials 247 248 +1
|
|
Updated the PR doing the following changes:
Still missing
I think that will be enough for a first PR. |
danburck
commented
Aug 9, 2022
There was a problem hiding this comment.
@facs95 Looks good, since it's already merged I think we should address the following things in future PRs:
- move remaining logic from eth/api.go (
GetTransactionByBlockNumberAndIndex(),GasPrice(),MaxPriorityFeePerGas(),GetTransactionLogs(),GetPendingTransactions()) - clean up interfaces. We probably don't need both interfaces
EVMBackendandEthereumAPIinterface. What do you think?
| // ProtocolVersion returns the supported Ethereum protocol version. | ||
| func (e *PublicAPI) ProtocolVersion() hexutil.Uint { | ||
| e.logger.Debug("eth_protocolVersion") | ||
| return hexutil.Uint(ethermint.ProtocolVersion) | ||
| } | ||
|
|
||
| // GasPrice returns the current gas price based on Ethermint's gas price oracle. |
There was a problem hiding this comment.
@facs95 Any reason, why you didn't move this endpoint logic?
There was a problem hiding this comment.
any method of PublicAPI gets exposed as an endpoint (eth_protocolVersion) its not the same when its a backend method. Those are not exposed. So I just moved the logic that use clientQuery or clientCtx to the backend. Anything that required state query.
facs95
added a commit
that referenced
this pull request
Aug 12, 2022
* move non api methods from eth/api.go to evm_backend: ClientCtx, QueryClient, Ctx, getBlockNumber, getTransactionByBlockAndIndex, doCall * organize eth/api.go into sections and move backend logic to dedicated files * remove unnecesary comment * move resend to the backend * refractor eth api * refractor debug namespace * refactor miner namespace * refactor personal namespace * update transactionReceipt from upstream * update getBlockByNumber from upstream * update getBalance from upstream * update getProof from upstream * update getBalance from upstream * fix linter * remove duplicated import * remove duplicated import * fix backend tests * fix lint * fix duplicated imports * fix linter * reorganize blocks * backend folder refractor * remove unnecessary file * remove duplicate import Co-authored-by: Freddy Caceres <facs95@gmail.com>
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Aug 17, 2022
* move non api methods from eth/api.go to evm_backend: ClientCtx, QueryClient, Ctx, getBlockNumber, getTransactionByBlockAndIndex, doCall * organize eth/api.go into sections and move backend logic to dedicated files * remove unnecesary comment * move resend to the backend * refractor eth api * refractor debug namespace * refactor miner namespace * refactor personal namespace * update transactionReceipt from upstream * update getBlockByNumber from upstream * update getBalance from upstream * update getProof from upstream * update getBalance from upstream * fix linter * remove duplicated import * remove duplicated import * fix backend tests * fix lint * fix duplicated imports * fix linter * reorganize blocks * backend folder refractor * remove unnecessary file * remove duplicate import Co-authored-by: Freddy Caceres <facs95@gmail.com>
9 tasks
devon-chain
pushed a commit
to FunctionX/ethermint
that referenced
this pull request
Nov 17, 2022
* move non api methods from eth/api.go to evm_backend: ClientCtx, QueryClient, Ctx, getBlockNumber, getTransactionByBlockAndIndex, doCall * organize eth/api.go into sections and move backend logic to dedicated files * remove unnecesary comment * move resend to the backend * refractor eth api * refractor debug namespace * refactor miner namespace * refactor personal namespace * update transactionReceipt from upstream * update getBlockByNumber from upstream * update getBalance from upstream * update getProof from upstream * update getBalance from upstream * fix linter * remove duplicated import * remove duplicated import * fix backend tests * fix lint * fix duplicated imports * fix linter * reorganize blocks * backend folder refractor * remove unnecessary file * remove duplicate import Co-authored-by: Freddy Caceres <facs95@gmail.com> (cherry picked from commit d43386d)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reorganizes the JSON-RPC apis and backend.
Right now the changes include an example for the following proposal:
use
namespace/ethereum/<namespace>/api.gofiles for an overview of exposed apisuse
backendfor api logic. Separate into several backend logic files: