Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Fix GasPrice calculation with relation to MinGasPrice #1138

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Fix GasPrice calculation with relation to MinGasPrice #1138

merged 3 commits into from
Jun 21, 2022

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

Small change on our RPC. MinGasPrice was not being compared correctly.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

danburck
danburck approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fedekunze
fedekunze approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. @crypto-facs can you add a bugfix changelog entry?

@fedekunze fedekunze merged commit 494d646 into evmos:main Jun 21, 2022
devon-chain pushed a commit to FunctionX/ethermint that referenced this pull request Jun 22, 2022
@crypto-facs @fedekunze @devon-chain
fix(rpc): Fix GasPrice calculation with relation to MinGasPrice (e…
8075504 
…vmos#1138)

* fix gasPrice minGasPrice comparison

* update changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@danburck danburck danburck approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crypto-facs @fedekunze @danburck