Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

enforce eip-155 to protect against replay #1122

Closed
yihuang opened this issue Jun 10, 2022 · 1 comment · Fixed by #1124
Closed

enforce eip-155 to protect against replay #1122

yihuang opened this issue Jun 10, 2022 · 1 comment · Fixed by #1124
Labels
C:x/evm EVM module

Comments

@yihuang
Copy link
Contributor

yihuang commented Jun 10, 2022 •
edited
Loading

Proposal: enforce eip-155 to protect against replay

Current behavior:

Right now, non-eip155 txs are still accepted, which opens room for replaying old ethereum tx on ethermint, similar to what happened on optimism recently.

Desired behavior:

Reject those txs and close the room for a potential attack.

Use case: [Why is this important (helps with prioritizing requests)]

Requests may be closed if we're not actively planning to work on them.
@fedekunze
Copy link
Contributor

fedekunze commented Jun 10, 2022 •
edited
Loading

Agree, we introduce a parameter in the EVM to disable the LegacyTx type. This should be checked in the AnteHandler so that the user doesn't spend gas

@fedekunze fedekunze added the C:x/evm EVM module label Jun 10, 2022
yihuang added a commit to yihuang/ethermint that referenced this issue Jun 10, 2022
@yihuang
Reject not replay-protected tx to prevent replay attack
f862fbf 
Closes: evmos#1122

- reject such txs in ante handler
@yihuang yihuang mentioned this issue Jun 10, 2022
Merged
11 tasks
yihuang added a commit to yihuang/ethermint that referenced this issue Jun 13, 2022
@yihuang
Reject not replay-protected tx to prevent replay attack
1c29870 
Closes: evmos#1122

- reject such txs in ante handler

add reject unprotected parameter

Update CHANGELOG.md

Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

pr suggestions

add unit test case

use var
fedekunze added a commit that referenced this issue Jun 13, 2022
@yihuang @fedekunze
!feat(evm): Reject not replay-protected tx to prevent replay attack (#…
8f932dd 
…1124)

* Reject not replay-protected tx to prevent replay attack

Closes: #1122

- reject such txs in ante handler

* add reject unprotected parameter

* Update CHANGELOG.md

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* pr suggestions

* add unit test case

* Reject not replay-protected tx to prevent replay attack

Closes: #1122

- reject such txs in ante handler

add reject unprotected parameter

Update CHANGELOG.md

Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

pr suggestions

add unit test case

use var

* add migrations

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* rename

* update comments

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain pushed a commit to FunctionX/ethermint that referenced this issue Jun 20, 2022
@yihuang @fedekunze @devon-chain
!feat(evm): Reject not replay-protected tx to prevent replay attack (e…
549cbbd 
…vmos#1124)

* Reject not replay-protected tx to prevent replay attack

Closes: evmos#1122

- reject such txs in ante handler

* add reject unprotected parameter

* Update CHANGELOG.md

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* pr suggestions

* add unit test case

* Reject not replay-protected tx to prevent replay attack

Closes: evmos#1122

- reject such txs in ante handler

add reject unprotected parameter

Update CHANGELOG.md

Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

pr suggestions

add unit test case

use var

* add migrations

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* rename

* update comments

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C:x/evm EVM module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Reject not replay-protected tx to prevent replay attack yihuang/ethermint
2 participants
@yihuang @fedekunze