add changelog and fix linter

CHANGELOG.md

@@ -68,6 +68,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (evm) [tharsis#901](https://github.com/tharsis/ethermint/pull/901) Support multiple MsgEthereumTx in single tx.
 * (config) [tharsis#908](https://github.com/tharsis/ethermint/pull/908) Add api.enable flag for Cosmos SDK Rest server
 * (feemarket) [tharsis#919](https://github.com/tharsis/ethermint/pull/919) Initialize baseFee in default genesis state.
+* (feemarket) [tharsis#943](https://github.com/tharsis/ethermint/pull/943) Store the base fee as a module param instead of using state storage.
 
 ### Bug Fixes
 

app/ante/utils_test.go

@@ -58,8 +58,8 @@ func (suite *AnteTestSuite) SetupTest() {
 			feemarketGenesis := feemarkettypes.DefaultGenesisState()
 			feemarketGenesis.Params.EnableHeight = 1
 			feemarketGenesis.Params.NoBaseFee = false
-			bf, _ :=  sdk.NewIntFromString(feemarketGenesis.Params.BaseFee)
-			feemarketGenesis.DefaultBaseFee =bf
+			bf, _ := sdk.NewIntFromString(feemarketGenesis.Params.BaseFee)
+			feemarketGenesis.DefaultBaseFee = bf
 			// Verify feeMarket genesis
 			err := feemarketGenesis.Validate()
 			suite.Require().NoError(err)

x/evm/keeper/keeper_test.go

@@ -91,7 +91,7 @@ func (suite *KeeperTestSuite) DoSetupTest(t require.TestingT) {
 		if suite.enableFeemarket {
 			feemarketGenesis.Params.EnableHeight = 1
 			feemarketGenesis.Params.NoBaseFee = false
-			bf, _  := sdk.NewIntFromString(feemarketGenesis.Params.BaseFee)
+			bf, _ := sdk.NewIntFromString(feemarketGenesis.Params.BaseFee)
 			feemarketGenesis.DefaultBaseFee = bf
 		} else {
 			feemarketGenesis.Params.NoBaseFee = true

x/feemarket/genesis.go

@@ -29,8 +29,8 @@ func ExportGenesis(ctx sdk.Context, k keeper.Keeper) *types.GenesisState {
 	}
 
 	return &types.GenesisState{
-		Params:   k.GetParams(ctx),
-		DefaultBaseFee:  baseFee,
-		BlockGas: k.GetBlockGasUsed(ctx),
+		Params:         k.GetParams(ctx),
+		DefaultBaseFee: baseFee,
+		BlockGas:       k.GetBlockGasUsed(ctx),
 	}
 }

x/feemarket/keeper/params.go

@@ -1,9 +1,10 @@
 package keeper
 
 import (
+	"math/big"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/tharsis/ethermint/x/feemarket/types"
-	"math/big"
 )
 
 // GetParams returns the total set of fee market parameters.
@@ -39,4 +40,4 @@ func (k Keeper) GetBaseFee(ctx sdk.Context) *big.Int {
 // SetBaseFee set's the base fee in the paramSpace
 func (k Keeper) SetBaseFee(ctx sdk.Context, baseFee *big.Int) {
 	k.paramSpace.Set(ctx, types.ParamStoreKeyBaseFee, baseFee.String())
-}
+}

x/feemarket/types/genesis.go

@@ -12,17 +12,17 @@ func DefaultGenesisState() *GenesisState {
 	return &GenesisState{
 		Params: DefaultParams(),
 		// the default base fee should be initialized because the default enable height is zero.
-		DefaultBaseFee:  sdk.NewIntFromUint64(params.InitialBaseFee),
-		BlockGas: 0,
+		DefaultBaseFee: sdk.NewIntFromUint64(params.InitialBaseFee),
+		BlockGas:       0,
 	}
 }
 
 // NewGenesisState creates a new genesis state.
 func NewGenesisState(params Params, baseFee sdk.Int, blockGas uint64) *GenesisState {
 	return &GenesisState{
-		Params:   params,
-		DefaultBaseFee:  baseFee,
-		BlockGas: blockGas,
+		Params:         params,
+		DefaultBaseFee: baseFee,
+		BlockGas:       blockGas,
 	}
 }
 

x/feemarket/types/genesis_test.go

@@ -47,18 +47,18 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 		{
 			"empty genesis",
 			&GenesisState{
-				Params:   Params{},
-				DefaultBaseFee:  sdk.ZeroInt(),
-				BlockGas: 0,
+				Params:         Params{},
+				DefaultBaseFee: sdk.ZeroInt(),
+				BlockGas:       0,
 			},
 			false,
 		},
 		{
 			"base fee is negative",
 			&GenesisState{
-				Params:   Params{},
-				DefaultBaseFee:  sdk.OneInt().Neg(),
-				BlockGas: 0,
+				Params:         Params{},
+				DefaultBaseFee: sdk.OneInt().Neg(),
+				BlockGas:       0,
 			},
 			false,
 		},

x/feemarket/types/params.go

@@ -16,7 +16,7 @@ var (
 	ParamStoreKeyNoBaseFee                = []byte("NoBaseFee")
 	ParamStoreKeyBaseFeeChangeDenominator = []byte("BaseFeeChangeDenominator")
 	ParamStoreKeyElasticityMultiplier     = []byte("ElasticityMultiplier")
-	ParamStoreKeyBaseFee           		  = []byte("BaseFee")
+	ParamStoreKeyBaseFee                  = []byte("BaseFee")
 	ParamStoreKeyEnableHeight             = []byte("EnableHeight")
 )
 
@@ -31,7 +31,7 @@ func NewParams(noBaseFee bool, baseFeeChangeDenom, elasticityMultiplier uint32,
 		NoBaseFee:                noBaseFee,
 		BaseFeeChangeDenominator: baseFeeChangeDenom,
 		ElasticityMultiplier:     elasticityMultiplier,
-		BaseFee:         		  strconv.FormatInt(baseFee, 10),
+		BaseFee:                  strconv.FormatInt(baseFee, 10),
 		EnableHeight:             enableHeight,
 	}
 }
@@ -42,7 +42,7 @@ func DefaultParams() Params {
 		NoBaseFee:                false,
 		BaseFeeChangeDenominator: params.BaseFeeChangeDenominator,
 		ElasticityMultiplier:     params.ElasticityMultiplier,
-		BaseFee:          		  strconv.FormatInt(params.InitialBaseFee, 10),
+		BaseFee:                  strconv.FormatInt(params.InitialBaseFee, 10),
 		EnableHeight:             0,
 	}
 }
@@ -64,10 +64,9 @@ func (p Params) Validate() error {
 		return fmt.Errorf("base fee change denominator cannot be 0")
 	}
 
-	baseFee , valid := new(big.Int).SetString(p.BaseFee, 10)
+	baseFee, valid := new(big.Int).SetString(p.BaseFee, 10)
 	if !valid {
 		return fmt.Errorf("not a valid base fee: %s", p.BaseFee)
-
 	}
 
 	if baseFee.Sign() < 0 {
@@ -120,10 +119,9 @@ func validateBaseFee(i interface{}) error {
 		return fmt.Errorf("invalid parameter type: %T", i)
 	}
 
-	baseFee , valid := new(big.Int).SetString(value, 10)
+	baseFee, valid := new(big.Int).SetString(value, 10)
 	if !valid {
 		return fmt.Errorf("not a valid base fee: %s", baseFee)
-
 	}
 
 	if baseFee.Sign() < 0 {