Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Commit

Permalink
fix: remove duplicated gasPrice derivation (#836)
Browse files Browse the repository at this point in the history
Noticed in an audit, this change removes a duplicated gasPrice
conversion that was first made in:
https://github.com/tharsis/ethermint/blob/423944bf799816b6db214fabebcf1b334d3b0826/x/evm/types/tx_args.go#L76-L78

as well as in

https://github.com/tharsis/ethermint/blob/423944bf799816b6db214fabebcf1b334d3b0826/x/evm/types/tx_args.go#L88-L90

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
  • Loading branch information
odeke-em and fedekunze committed Dec 15, 2021
1 parent 68f1d1c commit 5d237a5
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions x/evm/types/tx_args.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ func (args *TransactionArgs) ToTransaction() *MsgEthereumTx {
maxPriorityFeePerGas = sdk.NewIntFromBigInt(args.MaxPriorityFeePerGas.ToInt())
}

if args.GasPrice != nil {
gasPrice = sdk.NewIntFromBigInt(args.GasPrice.ToInt())
}

if args.Value != nil {
value = sdk.NewIntFromBigInt(args.Value.ToInt())
}
Expand Down

0 comments on commit 5d237a5

Please sign in to comment.