Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some f-strings don't parse correctly #839

Closed
evhub opened this issue May 28, 2024 · 1 comment
Closed

Some f-strings don't parse correctly #839

evhub opened this issue May 28, 2024 · 1 comment

Comments

@evhub
Copy link
Owner

evhub commented May 28, 2024

E.g.

import foo

bar = f"{foo}"
@evhub evhub added the bug label May 28, 2024
@evhub evhub added this to the v3.2.0 milestone May 28, 2024
@evhub
Copy link
Owner Author

evhub commented May 29, 2024

Nevermind, looks like the actual error here is with invalid f-string parsing in some instances. Here's the test case:

f"""
cd "{ROOT_DIR}"
git pull
py -3 -m pip install -Ue .
py -3 -m minecraft_server_tools.install_client{install_client_args}
{OPEN_CMD}"{LAUNCHER_FILE}"
    """.strip()

@evhub evhub changed the title Imports only used in f-strings are marked as unused Some f-strings don't parse correctly May 29, 2024
evhub added a commit that referenced this issue May 29, 2024
@evhub evhub added the resolved label May 29, 2024
@evhub evhub closed this as completed May 29, 2024
evhub added a commit that referenced this issue Jun 9, 2024
See Coconut's
[documentation](http://coconut.readthedocs.io/en/develop/DOCS.html) for
more information on all of the features listed below.

Language features:
* #833: New `case def` syntax for more easily defining pattern-matching
functions with many patterns.
* #811: New `f(name=)` syntax as a shorthand for `f(name=name)`,
replacing the now deprecated `f(...=name)` syntax.
* #836: New `CoconutWarning` built-in used for Coconut runtime warnings.

Compiler features:
* #837: Coconut will now warn about implicit string concatenation and
disable it completely with `--strict`.
* #718: Coconut will now warn about use of `addpattern def` without a
prior `match def`. This was a previously-supported feature to make
pattern-matching functions with many patterns easier to write, but the
new recommended way to do that is now via `case def`.
* #785: Initial [pyright](https://github.com/microsoft/pyright) support
via the `--pyright` flag.

Bugfixes:
* #839, #840: Fixed some f-string parsing issues.
* #834: Fixed `len` of empty `zip` objects.
* #830: Improved use of colored output.
* #757: Improved PEP 695 support on Python 3.12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant