New feature: usefinalname #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2013 12:03
Maven allows to set a "finalName" - the name which will be used when a project builds jars or other files in the /target folder. This commit allows to set a <useFinalName/> parameter which will load the POM of a dependency and use the finalName field from it instead of the default "artifactId-version-classifier" scheme.
Add PomResolver to resolve parent POMs, build would otherwise fail.
|
Many thanks for a detailed explanation, Bert! Will review it soon. |
|
Seems Markdown eats unknown XML tags... I edited my comment, I meant a "<useFinalName>true</useFinalName>" parameter. |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin already has lots of goodness, but there is one thing which I haven't seen in any Maven plugin to date: using the finalName of a copied artifact as destination file name so that the copy plugin doesn't need a verbose configuration to get pretty filenames.
A short introduction: Maven allows to set a "finalName" for an artifact in the build section. This name will be used when a project builds jars or other files in the target folder. When an artifact gets deployed though, it uses the GAV Maven coordinates (and it should, otherwise Maven couldn't find it). However, no plugins exist which can download the artifact, resolve its POM and use the finalName to rename the artifact to its "human readable" form.
This set of commits does all of this to get rid of the default "artifactId-version-classifier" scheme, at least if you put a "<useFinalName>true</useFinalName>" parameter in a CopyDependency or CopyResource block.