[Fix] Missing translation #8724
Conversation
WalkthroughThis pull request involves updates to the desktop menu and localization files across multiple languages. The primary change is the addition of an "Install Plugin" menu option in the Changes
Suggested reviewers
Possibly related PRs
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
packages/ui-core/i18n/assets/i18n/fr.json (1)
Missing Button Translations in French Language File
The following button translations are missing from the French language file and should be added:
- ENABLED: "Activé"
- DISABLED: "Désactivé"
- AUTO_SYNCING: "Synchronisation automatique..."
- SYNCING: "Synchronisation..."
- RESET_INTEGRATION: "Réinitialiser l'intégration"
- ADD_INTEGRATION: "Ajouter une intégration"
- SELECTED_TASKS: "Tâches sélectionnées"
- SENDING_CODE: "Envoi du code..."
🔗 Analysis chain
Line range hint
1-4077: Verify completeness of translations.The file appears to have comprehensive translations, but there are some keys that could benefit from additional context or improved translations.
Let's verify if any translation keys are missing or need improvement:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for missing translations by comparing with English file diff <(jq -r 'paths | join(".")' packages/ui-core/i18n/assets/i18n/en.json) <(jq -r 'paths | join(".")' packages/ui-core/i18n/assets/i18n/fr.json)Length of output: 258
Script:
#!/bin/bash # Check if translation files exist and are readable echo "Checking translation files..." ls -l packages/ui-core/i18n/assets/i18n/en.json packages/ui-core/i18n/assets/i18n/fr.json # Get a sample of translations to compare echo -e "\nSampling translations..." jq -r '.BUTTONS | keys' packages/ui-core/i18n/assets/i18n/en.json echo -e "\nFrench translations:" jq -r '.BUTTONS | keys' packages/ui-core/i18n/assets/i18n/fr.jsonLength of output: 5880
Script:
#!/bin/bash # Check specific translation values echo "Checking English values for missing keys..." for key in "ENABLED" "DISABLED" "AUTO_SYNCING" "SYNCING" "RESET_INTEGRATION" "ADD_INTEGRATION" "SELECTED_TASKS" "SENDING_CODE"; do echo -e "\n$key:" jq -r --arg key "$key" '.BUTTONS[$key]' packages/ui-core/i18n/assets/i18n/en.json done # Check if these translations exist elsewhere in the French file echo -e "\nSearching for translations in French file..." for key in "enabled" "disabled" "syncing" "integration" "selected" "sending"; do echo -e "\nSearching for '$key':" jq -r --arg key "$key" 'paths as $p | select(getpath($p) | tostring | ascii_downcase | contains($key)) | $p | join(".")' packages/ui-core/i18n/assets/i18n/fr.json | head -n 5 doneLength of output: 4688
🧹 Nitpick comments (2)
packages/ui-core/i18n/assets/i18n/fr.json (2)
4076-4077: Verify the new translation key addition.The new translation key "INSTALL_PLUGIN" has been added under the MENU section with the French translation "Installer plugin". The translation looks accurate but could be improved for better clarity.
Consider using a more specific translation:
- "INSTALL_PLUGIN": "Installer plugin" + "INSTALL_PLUGIN": "Installer le plugin"Adding the article "le" makes it more natural in French.
Line range hint
1-4077: Review of translation consistency and formatting.The translations are generally well-formatted and consistent, but there are a few minor issues to address:
- Some translations end with periods while similar phrases don't
- Some placeholders use different quotation marks ('{{ var }}' vs "{{ var }}")
- Some translations use different capitalization for similar terms
Consider standardizing:
- Period usage at the end of phrases
- Quotation mark style for placeholders
- Capitalization of common terms
This will improve maintainability and consistency of the translations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
packages/desktop-lib/src/lib/desktop-menu.ts(5 hunks)packages/ui-core/i18n/assets/i18n/ar.json(1 hunks)packages/ui-core/i18n/assets/i18n/bg.json(1 hunks)packages/ui-core/i18n/assets/i18n/de.json(1 hunks)packages/ui-core/i18n/assets/i18n/en.json(1 hunks)packages/ui-core/i18n/assets/i18n/es.json(1 hunks)packages/ui-core/i18n/assets/i18n/fr.json(1 hunks)packages/ui-core/i18n/assets/i18n/he.json(1 hunks)packages/ui-core/i18n/assets/i18n/it.json(1 hunks)packages/ui-core/i18n/assets/i18n/nl.json(1 hunks)packages/ui-core/i18n/assets/i18n/pl.json(1 hunks)packages/ui-core/i18n/assets/i18n/pt.json(1 hunks)packages/ui-core/i18n/assets/i18n/ru.json(1 hunks)packages/ui-core/i18n/assets/i18n/zh.json(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- packages/ui-core/i18n/assets/i18n/he.json
- packages/ui-core/i18n/assets/i18n/es.json
- packages/ui-core/i18n/assets/i18n/ru.json
- packages/ui-core/i18n/assets/i18n/pt.json
- packages/ui-core/i18n/assets/i18n/bg.json
- packages/ui-core/i18n/assets/i18n/ar.json
- packages/ui-core/i18n/assets/i18n/zh.json
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build
- GitHub Check: test
🔇 Additional comments (9)
packages/desktop-lib/src/lib/desktop-menu.ts (3)
17-26: Documentation formatting improved!Documentation comments now follow consistent JSDoc formatting with proper asterisks alignment.
241-244: Documentation formatting improved!Documentation comments for the pluginMenu getter now follow consistent JSDoc formatting.
255-257: New menu item added correctlyThe "Install Plugin" menu item has been properly added under the TIMER_TRACKER.MENU namespace, maintaining consistency with the existing menu structure.
packages/ui-core/i18n/assets/i18n/en.json (1)
4207-4208: Translation keys added correctlyNew translation keys for "MONTHLY_RECAP" and "INSTALL_PLUGIN" have been properly added to the TIMER_TRACKER.MENU section, maintaining consistency with the existing translation structure.
packages/ui-core/i18n/assets/i18n/nl.json (1)
4076-4077: LGTM! Translation looks good.The new Dutch translation "Plugin installeren" for "INSTALL_PLUGIN" is correctly added and properly formatted. The translation is grammatically correct and consistent with other menu items.
packages/ui-core/i18n/assets/i18n/pl.json (2)
4076-4077: New translation addition looks goodThe newly added translation for "INSTALL_PLUGIN" is correctly implemented:
"INSTALL_PLUGIN": "Zainstaluj wtyczkę"The translation is grammatically correct in Polish and maintains consistency with the application's terminology.
Line range hint
1-4077: Overall structure and formatting is well maintainedThe translation file follows proper JSON structure and maintains consistent formatting throughout. The hierarchical organization of translations is logical and well-maintained.
packages/ui-core/i18n/assets/i18n/it.json (1)
4076-4077: LGTM! The new Italian translations are accurate and consistent.The translations for "MONTHLY_RECAP" ("Riepilogo Mensile") and "INSTALL_PLUGIN" ("Installa plugin") are:
- Grammatically correct in Italian
- Consistent with the existing translation style
- Accurately convey the meaning of the English source text
packages/ui-core/i18n/assets/i18n/de.json (1)
4072-4073: LGTM! The German translation for "Install Plugin" is accurate and consistent.The translation "Plugin installieren" is:
- Grammatically correct
- Natural sounding in German
- Consistent with other menu items and plugin-related terms
- Follows the established capitalization pattern
|
View your CI Pipeline Execution ↗ for commit dae531b.
☁️ Nx Cloud last updated this comment at |
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by CodeRabbit
Localization
Documentation