-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Introduce server side pagination for selectors #8274
Merged
evereq
merged 46 commits into
develop
from
perf/introduce-server-side-pagination-for-selectors
Sep 27, 2024
Merged
[Perf] Introduce server side pagination for selectors #8274
evereq
merged 46 commits into
develop
from
perf/introduce-server-side-pagination-for-selectors
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver-side-pagination-for-tasks-table
…ver-side-pagination-for-tasks-table
…dated method call to getClientWithPagination
…on and caching functionality
…tors; updated task table component to use selected project and team IDs; refactored time tracker service to use toParams function
…ed task table component to display loading spinner, and refactored cached server data source to handle loading state
…to use distinctUntilChange and filter, and removed loading state handling from task table component
…Component, updated TimeTrackerService to include search term in API request
…nd team selector components and services
…ted template to use it
… and dimensions to .smart-table class
…ate employeeId condition
…dated imports and modules, and made minor template changes.
…ver-side-pagination-for-selectors
…ner, changed smart-table styles to use absolute positioning and added padding.
…nd team-selector components.
…date search logic, and add NG_VALUE_ACCESSOR provider
…ver-side-pagination-for-selectors
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a0f6810. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
...ges/desktop-ui-lib/src/lib/shared/features/client-selector/+state/client-selector.service.ts
Show resolved
Hide resolved
evereq
deleted the
perf/introduce-server-side-pagination-for-selectors
branch
September 27, 2024 19:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
https://www.loom.com/share/f50eb806406e435aa483dc1fb654cc14?sid=e461efb8-9e9e-410c-8e4a-8fcb6aae30d5