Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add relations status size priority task #6879

Conversation

adkif
Copy link
Contributor

@adkif adkif commented Sep 25, 2023

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


badalkhatri0924 and others added 30 commits August 23, 2023 20:08
chore: add HubStaff required env vars and also switch to NX Cloud
onDelete: 'SET NULL',
})
@JoinColumn()
taskPriority?: ITaskPriority;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adkif Why we added taskPriority additional field while we have priorit column?

Note: @adkif Same for other 2 columns why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have to update multiple places in GT if we implement this changes. @adkif @rahul-rocket

CC: @evereq

Copy link
Contributor Author

@adkif adkif Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahul-rocket we need to interact directly with objects using the @ManyToOne relationship. the use of text is limited and a greater cost is required

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adkif @badalkhatri0924 Yes. We can wait for @evereq for feedback on this PR.

…-ui-ux

Fix/improve desktop timer ng2smartTable UI/UX
…in-query

feat: add entity relationship support in query
…ctors-pages-backlog

Feat/improve tasks dialogs selectors pages backlog
@gitguardian
Copy link

gitguardian bot commented Sep 26, 2023

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8046933 Generic High Entropy Secret 07d2a5b nx.json View secret
8046933 Generic High Entropy Secret 60fa1f2 nx.json View secret
8046933 Generic High Entropy Secret fb00d71 nx.json View secret
8046933 Generic High Entropy Secret fb2dc58 nx.json View secret
8046933 Generic High Entropy Secret 77b50f4 nx.json View secret
8046933 Generic High Entropy Secret 3d419c7 nx.json View secret
8046933 Generic High Entropy Secret 8a5a21e nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@socket-security
Copy link

@evereq evereq merged commit ece94dd into refactor/get-task-statistics-service-method Sep 26, 2023
@evereq evereq deleted the feat/add-relations-status-size-priority-task branch September 26, 2023 10:11
@nx-cloud
Copy link

nx-cloud bot commented Sep 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8a5a21e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx serve api -c=production --prod

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants