[Fix] Report page that shows loading indicator should be cleared! #8340
Assignees
Comments
2 tasks
rahul-rocket
added a commit
that referenced
this issue
Oct 10, 2024
…or-report-page [Fix] 8340 Clear Data During Loading
samuelmbabhazi
pushed a commit
that referenced
this issue
Oct 11, 2024
evereq
added a commit
that referenced
this issue
Oct 13, 2024
* fix: #8339 employee & organization parameters to URLs * fix: #8339 project parameters to URLs * fix: #8339 date range picker parameters to URLs * fix: #8339 project parameters to URLs * fix: don't merge new config with old default config * fix: don't merge new config with old default config * fix: organization controller and module improvement * feat: add standardWorkHoursPerDay column to organization entity * feat: #8341 add standardWorkHoursPerDay column migration to organization entity * feat: #8341 add standardWorkHoursPerDay column migration to organization table * feat: #8341 add standardWorkHoursPerDay column migration to tenant table * fix: create/update standard work hours per day * feat: get task by view query model * feat: get task by view query DTO * feat: get tasks by view filter API * fix: save standard work hours per day for organization * fix: get tasks by view filters * fix: remove unused DTO * chore(deps): add chartjs-plugin-annotation chore: add chartjs-plugin-annotation package for annotation support in charts * fix: organization ID filter in query * feat: add translations for Standard Work Hours * feat: #8341 added horizontal dotted line * fix(deepscan): removed unused import * fix(coderrabitai): improve types and finders * fix: sprint DELETE role permission * fix: improve sprints role permissions * fix: #8340 clear data before loading on report pages * fix: issue type value using enum * fix(deepscan): removed unused import * feat: #8339 bookmark query params builder resolver * [Feat] Add new workspace's methods to desktop authentication service (#8375) * feat: add new methods to service * feat: remove unecessary try-catch blocks and type annotations for return values in AuthService methods. * [Feat] Create Reusable Component and Add Workspace Links (#8383) * feat: export social links * feat: create a shared logo component * feat: create a shared social links component * feat: add reusable patterns to constants * feat: add link to magic workspace signin and use reusable logo, links and switch * feat: SwitchThemeModule, LogoComponent, and SocialLinksComponent to NgxLoginModule * fix(cspell): typo spelling :-) * fix: improvement suggested by CodeRabbit * fix: improvement suggested by CodeRabbit * fix: improvement suggested by CodeRabbit * fix: task type enum swagger * fix: issue type enum * feat: #8386 add module and entity for global logging of API * feat: #8386 add repository and subscriber for global logging of API * feat: #8386 table migration for "api_call_log" table * fix: #8386 circular dependency injection in repository * [Fix] Edit team functionality not working * feat: #8386 retrieves call logs API * fix(deepscan): property is accessed without null check * fix: missing role-permission module * fix: better encapsulation and reducing coupling between modules * fix: task view not found update command handler * [Fix] Filters not working * fix: #8386 added origin into `api_call_log` table * [Feat] Implement magic login (#8387) * feat: create reusable workspace selection component * feat: create debounce click directive * feat: create reusable avatar component * feat: implement login magic component * feat: implement login magic workspace component * feat: implement login workspace component * feat: reuse shared core styles * feat: add new component to login * feat: create authentication routes * feat: use lazy loading for authentications routes * fix: add code rabbit suggestions * fix: apply code rabbit suggestions * fix: apply code rabbit suggestions * [Fix] Task deselect on refresh (#8392) * fix: task deselect on refresh * fix: add `organizationTeamId` missing property to time tracker API request and spread `arg.timer` into the request object. * fix: apply code rabbit suggestion * [Fix] Edit contact for (client,customers,leads) functionality not working (#8393) * [Fix] Edit contact for (client,customers,leads) functionality not working * Remove member deletion * [Fix] Remote timer logic stop calls (#8394) * fix: remote timer logic and stopTimer calls * refactor: remote timer logic * [Feat] Resource Link Entity (#8397) * feat: add resource link model and entity * feat: resource link migration * [Feat] Resource Link API (#8399) * feat: add resource link model and entity * feat: resource link migration * feat: add resource link service * feat: resource link commands * feat: add resource link handlers * feat: add resource link subscriber * feat: add resource link controller and DTO * chore: desktop builds on Windows --------- Co-authored-by: Rahul R. <rahulrathore576@gmail.com> Co-authored-by: GloireMutaliko21 <mufunyig@gmail.com> Co-authored-by: Kifungo A <45813955+adkif@users.noreply.github.com> Co-authored-by: samuelmbabhazi <samuelmbabhazi@gmail.com> Co-authored-by: samuel mbabhazi <111171386+samuelmbabhazi@users.noreply.github.com> Co-authored-by: Gloire Mutaliko (Salva) <86450367+GloireMutaliko21@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description: The body of the report that shows loading indicator should be cleared!
you can see it shows OLD information and loading indicator, that's BAD because user may not notice that it shows loading and will read old information (i.e. from other selected person or interval!)
So when we display loading, let's clear the content of the report part where you show loading indicator!
Like below you can see I selected "Gloire" in the header, but it display Kostya records and loading indicator:
The text was updated successfully, but these errors were encountered: