Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Jitsu backend intergration #6924

Closed
nelsonBlack opened this issue Oct 3, 2023 · 1 comment · Fixed by #6935
Closed

[Feature] Jitsu backend intergration #6924

nelsonBlack opened this issue Oct 3, 2023 · 1 comment · Fixed by #6935
Assignees
Labels
type: enhancement ✨ New feature or request
Milestone

Comments

@nelsonBlack
Copy link
Contributor

@rahul-rocket
Copy link
Collaborator

Just to summarize all, let me send this:

  1. Remove "subscribers.push" inside contructor.
  2. Remove injection of service JitsuAnalyticsService in the constuctor.
  3. Manually create JitsuAnalyticsService instance, same as logger.
  4. Move that JitsuEventsSubscriber to be part of the "registration" of subscribers that we already have for all 50 others
  5. Test everything

rahul-rocket added a commit that referenced this issue Oct 6, 2023
rahul-rocket added a commit that referenced this issue Oct 6, 2023
rahul-rocket added a commit that referenced this issue Oct 6, 2023
rahul-rocket added a commit that referenced this issue Oct 6, 2023
rahul-rocket added a commit that referenced this issue Oct 7, 2023
rahul-rocket added a commit that referenced this issue Oct 7, 2023
…ergration

[feat] #6924 jitsu backend api integration
@evereq evereq assigned evereq and unassigned nelsonBlack Nov 18, 2023
@evereq evereq added this to the v0.9 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants