refactor: async-await usage in conflict deletion logic to prevent map…

… misuse
ever-co · Sep 23, 2024 · ed0f9ce · ed0f9ce
1 parent c61f9ae
commit ed0f9ce
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/core/src/time-tracking/timer/timer.service.ts b/packages/core/src/time-tracking/timer/timer.service.ts
@@ -378,11 +378,11 @@ export class TimerService {
 
 				// Delete conflicts
 				await Promise.all(
-					await conflicts.flatMap((timeLog: ITimeLog) => {
+					conflicts.flatMap((timeLog: ITimeLog) => {
 						const { timeSlots = [] } = timeLog;
-						timeSlots.map(async (timeSlot: ITimeSlot) => {
-							await this.commandBus.execute(new DeleteTimeSpanCommand(times, timeLog, timeSlot));
-						});
+						return timeSlots.map((timeSlot: ITimeSlot) =>
+							this.commandBus.execute(new DeleteTimeSpanCommand(times, timeLog, timeSlot))
+						);
 					})
 				);
 			}