fix: improvement suggested by CodeRabbit

packages/ui-core/core/src/lib/resolvers/bookmark-query-params.resolver.ts

@@ -3,6 +3,7 @@ import { ActivatedRouteSnapshot, ResolveFn } from '@angular/router';
 import { EMPTY, Observable, of } from 'rxjs';
 import { Store } from '../services/store/store.service';
 import { DEFAULT_SELECTOR_VISIBILITY } from '../services/selector-builder/selector-builder.service';
+import { ErrorHandlingService } from '../services/notification/error-handling.service';
 
 /**
  * The `BookmarkQueryParamsResolver` is responsible for constructing a set of query parameters
@@ -17,12 +18,13 @@ import { DEFAULT_SELECTOR_VISIBILITY } from '../services/selector-builder/select
 export const BookmarkQueryParamsResolver: ResolveFn<Observable<Record<string, string>>> = (
 	route: ActivatedRouteSnapshot
 ): Observable<Record<string, string>> => {
+	// Get injected services
+	const _store = inject(Store);
+	const _errorHandlingService = inject(ErrorHandlingService);
+
 	try {
 		// Get selectors visibility and selected entities
 		const selectors = Object.assign({}, DEFAULT_SELECTOR_VISIBILITY, route.data?.selectors);
-
-		// Get injected services
-		const _store = inject(Store);
 		const { selectedOrganization, selectedEmployee, selectedProject, selectedTeam } = _store;
 
 		// Map selectors to entity IDs
@@ -46,7 +48,7 @@ export const BookmarkQueryParamsResolver: ResolveFn<Observable<Record<string, st
 	} catch (error) {
 		// Handle any synchronous errors and redirect to "new integration" page
 		console.log(`Error resolving entity query params: ${error}`);
-		// Return an empty observable
-		return EMPTY;
+		_errorHandlingService.handleError(error);
+		return EMPTY; // Return an empty observable
 	}
 };

packages/ui-core/core/src/lib/services/selector-builder/date-range-picker-builder.service.ts

@@ -24,31 +24,31 @@ export const DEFAULT_DATE_RANGE: IDateRangePicker = {
 
 @Injectable({ providedIn: 'root' })
 export class DateRangePickerBuilderService {
+	public dates$: BehaviorSubject<IDateRangePicker> = new BehaviorSubject(DEFAULT_DATE_RANGE);
 	private _datePickerConfig$: BehaviorSubject<IDatePickerConfig | null> = new BehaviorSubject(null);
 	public datePickerConfig$: Observable<IDatePickerConfig | null> = this._datePickerConfig$.asObservable();
-
 	private _selectedDateRange$: BehaviorSubject<IDateRangePicker | null> = new BehaviorSubject(null);
 	public selectedDateRange$: Observable<IDateRangePicker | null> = this._selectedDateRange$.asObservable();
 
-	public dates$: BehaviorSubject<IDateRangePicker> = new BehaviorSubject(DEFAULT_DATE_RANGE);
-
-	/**
-	 * Gets the currently selected date range.
-	 */
-	get selectedDateRange(): IDateRangePicker {
-		return this.dates$.getValue();
-	}
 	/**
 	 * Sets a new selected date range.
 	 *
 	 * @param range - The new date range to set.
 	 */
 	set selectedDateRange(range: IDateRangePicker) {
-		if (isNotEmpty(range)) {
+		if (range) {
 			this._selectedDateRange$.next(range);
+			this.dates$.next(range);
 		}
 	}
 
+	/**
+	 * Gets the currently selected date range.
+	 */
+	get selectedDateRange(): IDateRangePicker {
+		return this.dates$.getValue();
+	}
+
 	/**
 	 * Gets the current date picker configuration.
 	 */

packages/ui-core/shared/src/lib/selectors/project/project/project.component.ts

@@ -84,7 +84,7 @@ export class ProjectSelectorComponent implements OnInit, OnDestroy, AfterViewIni
 	 * The placeholder text to be displayed in the project selector.
 	 * Provides guidance to the user on what action to take or what information to provide.
 	 *
-\	 */
+	 */
 	@Input() placeholder: string | null = null;
 
 	/**
@@ -120,7 +120,7 @@ export class ProjectSelectorComponent implements OnInit, OnDestroy, AfterViewIni
 	public set projectId(value: ID | ID[]) {
 		this._projectId = value;
 		this.onChange(value);
-		this.onTouched(value);
+		this.onTouched();
 	}
 
 	/**
@@ -182,7 +182,7 @@ export class ProjectSelectorComponent implements OnInit, OnDestroy, AfterViewIni
 	/**
 	 * Callback function to notify touch events in the form control.
 	 */
-	private onTouched: (value: ID | ID[]) => void = () => {};
+	private onTouched: () => void = () => {};
 
 	constructor(
 		private readonly _organizationProjects: OrganizationProjectsService,
@@ -352,7 +352,7 @@ export class ProjectSelectorComponent implements OnInit, OnDestroy, AfterViewIni
 	 *
 	 * @param fn - The callback function to register for the 'onChange' event.
 	 */
-	registerOnChange(fn: (value: any) => void): void {
+	registerOnChange(fn: (value: ID | ID[]) => void): void {
 		this.onChange = fn;
 	}
 

packages/ui-core/shared/src/lib/selectors/team/team/team.component.ts

@@ -120,7 +120,7 @@ export class TeamSelectorComponent implements OnInit, OnDestroy {
 	public set teamId(value: ID | ID[]) {
 		this._teamId = value;
 		this.onChange(value);
-		this.onTouched(value);
+		this.onTouched();
 	}
 
 	/**
@@ -182,7 +182,7 @@ export class TeamSelectorComponent implements OnInit, OnDestroy {
 	/**
 	 * Callback function to notify touch events in the form control.
 	 */
-	private onTouched: (value: ID | ID[]) => void = () => {};
+	private onTouched: () => void = () => {};
 
 	constructor(
 		private readonly _activatedRoute: ActivatedRoute,
@@ -339,7 +339,7 @@ export class TeamSelectorComponent implements OnInit, OnDestroy {
 	 *
 	 * @param fn - The callback function to register for the 'onChange' event.
 	 */
-	registerOnChange(fn: (value: any) => void): void {
+	registerOnChange(fn: (value: ID | ID[]) => void): void {
 		this.onChange = fn;
 	}