-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRUD functionality to eventespresso/core
wp.data store.
#780
Commits on Jan 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for bf34a46 - Browse repository at this point
Copy the full SHA bf34a46View commit details -
dispatch resolution for
getEntityById
when new entities are added f……rom lists store
Configuration menu - View commit details
-
Copy full SHA for 8834468 - Browse repository at this point
Copy the full SHA 8834468View commit details -
Configuration menu - View commit details
-
Copy full SHA for b85c065 - Browse repository at this point
Copy the full SHA b85c065View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8808625 - Browse repository at this point
Copy the full SHA 8808625View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1086e75 - Browse repository at this point
Copy the full SHA 1086e75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e4129a - Browse repository at this point
Copy the full SHA 6e4129aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb13649 - Browse repository at this point
Copy the full SHA fb13649View commit details -
Configuration menu - View commit details
-
Copy full SHA for f25ab92 - Browse repository at this point
Copy the full SHA f25ab92View commit details -
Configuration menu - View commit details
-
Copy full SHA for beabf8c - Browse repository at this point
Copy the full SHA beabf8cView commit details -
adding tests and related fixes
Not complete yet, just work done so far. So test fails are expected still.
Configuration menu - View commit details
-
Copy full SHA for cd80bbd - Browse repository at this point
Copy the full SHA cd80bbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c07c75c - Browse repository at this point
Copy the full SHA c07c75cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f88fc18 - Browse repository at this point
Copy the full SHA f88fc18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2502b5e - Browse repository at this point
Copy the full SHA 2502b5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84b2182 - Browse repository at this point
Copy the full SHA 84b2182View commit details -
add helper and test for getting an array of ids from an Array of Base…
…Entity instances
Configuration menu - View commit details
-
Copy full SHA for 4620877 - Browse repository at this point
Copy the full SHA 4620877View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85a236b - Browse repository at this point
Copy the full SHA 85a236bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d034a21 - Browse repository at this point
Copy the full SHA d034a21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 288881c - Browse repository at this point
Copy the full SHA 288881cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e5771b - Browse repository at this point
Copy the full SHA 8e5771bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f582e - Browse repository at this point
Copy the full SHA e4f582eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b83de3c - Browse repository at this point
Copy the full SHA b83de3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a7b15e - Browse repository at this point
Copy the full SHA 7a7b15eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63b103b - Browse repository at this point
Copy the full SHA 63b103bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fed3653 - Browse repository at this point
Copy the full SHA fed3653View commit details -
Configuration menu - View commit details
-
Copy full SHA for b43d959 - Browse repository at this point
Copy the full SHA b43d959View commit details -
Configuration menu - View commit details
-
Copy full SHA for d97bf8b - Browse repository at this point
Copy the full SHA d97bf8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0aa96e - Browse repository at this point
Copy the full SHA b0aa96eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1341498 - Browse repository at this point
Copy the full SHA 1341498View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae0d740 - Browse repository at this point
Copy the full SHA ae0d740View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5d1030 - Browse repository at this point
Copy the full SHA d5d1030View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0959ae6 - Browse repository at this point
Copy the full SHA 0959ae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8744796 - Browse repository at this point
Copy the full SHA 8744796View commit details -
add helper method and tests for getting primary key query string
- This string is used in rest requests retreiving entities for a given set of ids.
Configuration menu - View commit details
-
Copy full SHA for 483fc69 - Browse repository at this point
Copy the full SHA 483fc69View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c940c - Browse repository at this point
Copy the full SHA e1c940cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e01e9ca - Browse repository at this point
Copy the full SHA e01e9caView commit details -
update lists store and tests for using immutable state.
- also adds getEntitiesByIds selector and resolver.
Configuration menu - View commit details
-
Copy full SHA for 9f066c2 - Browse repository at this point
Copy the full SHA 9f066c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2b252d - Browse repository at this point
Copy the full SHA d2b252dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2710b00 - Browse repository at this point
Copy the full SHA 2710b00View commit details -
fix eventespress/core state to account for plain object root
With the use of Redux.combineReducers (via wp.element), the root state is actually a plain object with all the individual state slices implementing immutable.js. In the tests I wrote, I was considering the entire state being an instance of Immutable.Map when that’s not actually the case! So the tests passed for that assumption but not really testing real-world use-case. Although we _could_ implement our own (or a redux-immutable) combineReduceers to make the root state an Immutable.Map()… that could have repercussions down the road for other bolt-on things exposed by WP for the data stores that expect the state root to be a plain obejct. I figured it’s safer and more future proof to simply have the state slices that matter using immutable (as the reducers/selectors are what will trigger re-renders).
Configuration menu - View commit details
-
Copy full SHA for 67f5718 - Browse repository at this point
Copy the full SHA 67f5718View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8862057 - Browse repository at this point
Copy the full SHA 8862057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7367c71 - Browse repository at this point
Copy the full SHA 7367c71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60bfca8 - Browse repository at this point
Copy the full SHA 60bfca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f3168 - Browse repository at this point
Copy the full SHA f2f3168View commit details -
various fixes to existing blocks and code after user testing
- existing event-attendees block (and related support components) needed updated to account for model entities no longer being a Map but rather a simple array (which imo is easier to work with). - After initial user monkey testing in the browser console, I discovered some other fixes needed in both the new code and automated tests (likely more to come as I keep testing).
Configuration menu - View commit details
-
Copy full SHA for 91567e3 - Browse repository at this point
Copy the full SHA 91567e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a783249 - Browse repository at this point
Copy the full SHA a783249View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d4d198 - Browse repository at this point
Copy the full SHA 5d4d198View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7fadb1 - Browse repository at this point
Copy the full SHA f7fadb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfef642 - Browse repository at this point
Copy the full SHA dfef642View commit details -
Configuration menu - View commit details
-
Copy full SHA for 286c0b9 - Browse repository at this point
Copy the full SHA 286c0b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d67e78 - Browse repository at this point
Copy the full SHA 7d67e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for a63d9b5 - Browse repository at this point
Copy the full SHA a63d9b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d8c1dc - Browse repository at this point
Copy the full SHA 4d8c1dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb91fc9 - Browse repository at this point
Copy the full SHA bb91fc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e823106 - Browse repository at this point
Copy the full SHA e823106View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d2f17e - Browse repository at this point
Copy the full SHA 6d2f17eView commit details -
remove dirty relations index actions and reducers
The index is still in the state, but exposing this level of granularity to clients created potential problems with order of execution etc. This state tree is more of an optimization (lookup) trick for internal use so I’ve taken care of automatically changing its state internally via the reducer rather than controlled via its own action.
Configuration menu - View commit details
-
Copy full SHA for 724e956 - Browse repository at this point
Copy the full SHA 724e956View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e686d7 - Browse repository at this point
Copy the full SHA 6e686d7View commit details -
implement reverse lookup for relations selector
- its possible that a relation is never indexed because its always listed as a relation to another entity in the state. So we need to have reverse lookup implemented for both getRelationAdditionsQueuedForModel and getRelationDeletionsQueuedForModel for those cases where client is looking for relations using a modelName that is not a key in the index.
Configuration menu - View commit details
-
Copy full SHA for ccab6cc - Browse repository at this point
Copy the full SHA ccab6ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7572c35 - Browse repository at this point
Copy the full SHA 7572c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf2b5d5 - Browse repository at this point
Copy the full SHA bf2b5d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f704ad9 - Browse repository at this point
Copy the full SHA f704ad9View commit details -
fix factory and schema selectors so they account for there being an e…
…mpty Map for the model
Configuration menu - View commit details
-
Copy full SHA for b5c804b - Browse repository at this point
Copy the full SHA b5c804bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02a857e - Browse repository at this point
Copy the full SHA 02a857eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95b08fb - Browse repository at this point
Copy the full SHA 95b08fbView commit details -
some more fixes to relations and entity removals
- this includes changes to `Immutable.Set().delete` usage. It accepts the _value_ to delete and that is much simpler than providing the key (although key seemed to work). - this includes some faulty logic fixes that was deleting from relation index unexpectedly and making sure tests were updated to catch that.
Configuration menu - View commit details
-
Copy full SHA for b4f2d30 - Browse repository at this point
Copy the full SHA b4f2d30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d39992 - Browse repository at this point
Copy the full SHA 9d39992View commit details -
Configuration menu - View commit details
-
Copy full SHA for 545a0a4 - Browse repository at this point
Copy the full SHA 545a0a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4610b75 - Browse repository at this point
Copy the full SHA 4610b75View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8661f3 - Browse repository at this point
Copy the full SHA a8661f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b61394 - Browse repository at this point
Copy the full SHA 3b61394View commit details -
Configuration menu - View commit details
-
Copy full SHA for 619b6d6 - Browse repository at this point
Copy the full SHA 619b6d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26def9c - Browse repository at this point
Copy the full SHA 26def9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c183d3 - Browse repository at this point
Copy the full SHA 3c183d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d481589 - Browse repository at this point
Copy the full SHA d481589View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3476cc - Browse repository at this point
Copy the full SHA a3476ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77ce9bf - Browse repository at this point
Copy the full SHA 77ce9bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48a0d3b - Browse repository at this point
Copy the full SHA 48a0d3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 564064f - Browse repository at this point
Copy the full SHA 564064fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93930b6 - Browse repository at this point
Copy the full SHA 93930b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 794d704 - Browse repository at this point
Copy the full SHA 794d704View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee19b93 - Browse repository at this point
Copy the full SHA ee19b93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 747f95b - Browse repository at this point
Copy the full SHA 747f95bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4afc1bf - Browse repository at this point
Copy the full SHA 4afc1bfView commit details -
switch usage of
shift()
topop()
- pop is more performant becuase the array does not need re-indexed. There’s no need to retain order here so `pop` is sufficient.
Configuration menu - View commit details
-
Copy full SHA for 6f787ee - Browse repository at this point
Copy the full SHA 6f787eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a890483 - Browse repository at this point
Copy the full SHA a890483View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ef9123 - Browse repository at this point
Copy the full SHA 9ef9123View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d9a1b0 - Browse repository at this point
Copy the full SHA 6d9a1b0View commit details
Commits on Jan 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5362800 - Browse repository at this point
Copy the full SHA 5362800View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9d21cb - Browse repository at this point
Copy the full SHA e9d21cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d71738 - Browse repository at this point
Copy the full SHA 9d71738View commit details
Commits on Jan 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3324fc5 - Browse repository at this point
Copy the full SHA 3324fc5View commit details
Commits on Jan 24, 2019
-
Merge branch 'master' into FET/add-crud-to-stores
# Conflicts: # assets/dist/build-manifest.json # assets/dist/ee-components.622f86c8649619cbcbcb.dist.js # assets/dist/ee-components.7d6c99591998d2eae4c0.dist.js # assets/dist/ee-components.b72fa352434166ef52be.dist.js # assets/dist/ee-data-stores.67b185e1920ba24c7431.dist.js # assets/dist/ee-model.7f810d358d08f82e088b.dist.js # assets/dist/ee-model.93606ab921bb65bfe8e0.dist.js # assets/dist/ee-model.b08f7f3ee436d1dbb468.dist.js
Configuration menu - View commit details
-
Copy full SHA for 9e4c752 - Browse repository at this point
Copy the full SHA 9e4c752View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf00eb - Browse repository at this point
Copy the full SHA dcf00ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b81735 - Browse repository at this point
Copy the full SHA 8b81735View commit details