Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add replaceDoc and replaceMany methods to prevent merge #19

Merged
merged 1 commit into from
Sep 30, 2020
Merged

feature: add replaceDoc and replaceMany methods to prevent merge #19

merged 1 commit into from
Sep 30, 2020

Conversation

internalsystemerror
Copy link
Contributor

This allows for documents to be replaced out right instead of merging with an existing document. For example, if the keys are dynamically generated, and needs to be removed from a new document, this would allow a way to do that.

Note that by adding the methods to the interface, this would pose a BC break upstream. This is addressed in PR: event-engine/php-postgres-document-store#16.

Relates to #17.

@codeliner codeliner merged commit 6f89111 into event-engine:master Sep 30, 2020
@codeliner
Copy link
Contributor

Thank you @internalsystemerror Great work!

@internalsystemerror internalsystemerror deleted the feature-replace-doc branch October 1, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants