-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): migrate users
/teams
to Astro new content layer API
#1169
refactor(core): migrate users
/teams
to Astro new content layer API
#1169
Conversation
🦋 Changeset detectedLatest commit: f0e2ef1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
95541f1
to
44b816d
Compare
…s-and-teams-to-new-astro-content-layer
Thanks @carlosallexandre let's give it ago! I did notice this, when I run
I'm wondering if its due to how this project is setup or not, going to merge and test on a proper catalog. But maybe that is something we should look at too, if its effecting end users, as it may cause some confusion |
Yeah seems like a local only issue, just tested lastest build and it was fine. |
It seems something that happens between the |
As I suspected, adding the PROJECT_DIR env to the type check command remove the warning. // scripts/build-ci.js
#!/usr/bin/env node
// This is used for CI on vercel. Must copy files before building.
import { join } from 'node:path';
import { execSync } from 'node:child_process';
const __dirname = import.meta.dirname;
const args = process.argv.slice(2);
const catalog = args[0] || 'default';
const catalogDir = join(__dirname, '../eventcatalog/');
const projectDIR = join(__dirname, `../examples/${catalog}`);
// Build cli
execSync('pnpm run build:bin', { stdio: 'inherit' });
// Run the generator
execSync(`cross-env NODE_ENV=CI PROJECT_DIR=${projectDIR} CATALOG_DIR=${catalogDir} npx . generate`, {
stdio: 'inherit',
});
// Build catalog
execSync(`cross-env NODE_ENV=CI PROJECT_DIR=${projectDIR} CATALOG_DIR=${catalogDir} npx . build`, {
stdio: 'inherit',
});
// Type check
execSync(`pnpm exec astro check --minimumSeverity error --root ${catalogDir}`, {
stdio: 'inherit',
env: {
...process.env,
PROJECT_DIR: projectDIR,
CATALOG_DIR: catalogDir,
},
}); |
Changes Introduced
eventcatalog/src/content/config.ts
toeventcatalog/src/content.config.ts
.glob
loader toteams
/users
collections.teams
/users
from the custom hydrate phase (src/catalog-to-astro-content-directory.js
)