Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore MSRV to 1.65.0 #442

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Restore MSRV to 1.65.0 #442

merged 2 commits into from
Sep 22, 2023

Conversation

samueltardieu
Copy link
Collaborator

  • Revert "Update codspeed-criterion-compat requirement from 1.1.0 to 2.1.0"
  • Revert "Update MSRV to 1.70.0"

@samueltardieu
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 22, 2023

Merge conflict.

@samueltardieu
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Sep 22, 2023
442: Restore MSRV to 1.65.0 r=samueltardieu a=samueltardieu

- Revert "Update codspeed-criterion-compat requirement from 1.1.0 to 2.1.0"
- Revert "Update MSRV to 1.70.0"


Co-authored-by: Samuel Tardieu <sam@rfc1149.net>
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2023

CodSpeed Performance Report

Merging #442 will degrade performances by 17.28%

Comparing restore-msrv (da496db) with main (315218d)

🎉 Hooray! codspeed-rust just leveled up to 1.1.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 9 improvements
❌ 9 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main restore-msrv Change
corner_to_corner_astar 420.1 µs 432.8 µs -2.93%
no_path_bfs 6.2 ms 5.7 ms +8.69%
no_path_fringe 11.8 ms 11.6 ms +2.19%
fill-corner_to_corner_dijkstra 7.4 ms 7.8 ms -5.76%
corner_to_corner_bfs 6 ms 6.1 ms -2.09%
corner_to_corner_idastar 589.8 µs 628.8 µs -6.21%
fill-corner_to_corner_fringe 668.5 µs 499.8 µs +33.76%
fill-corner_to_corner_bfs 5.6 ms 6.5 ms -13.5%
fill-corner_to_corner_idastar 557.7 µs 576.7 µs -3.29%
arena 256 ms 249.8 ms +2.5%
fill-no_path_astar 7 ms 8.3 ms -15.83%
no_path_dijkstra 7.8 ms 7.6 ms +3.38%
fill-corner_to_corner_iddfs 26 ms 24.4 ms +6.65%
fill-no_path_dijkstra 7.3 ms 6.8 ms +7.87%
fill-no_path_fringe 7.2 ms 7.7 ms -6.83%
fill-no_path_bfs 5.6 ms 6.8 ms -17.28%
separate_components 43.9 ms 42.2 ms +4.21%
fill-corner_to_corner_astar 639.7 µs 547 µs +16.96%

@samueltardieu samueltardieu merged commit 0d84d4f into main Sep 22, 2023
@bors bors bot deleted the restore-msrv branch September 22, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant