Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualise Vehicle SoC Limit #4245

Merged
merged 8 commits into from
Sep 2, 2022
Merged

Visualise Vehicle SoC Limit #4245

merged 8 commits into from
Sep 2, 2022

Conversation

naltatis
Copy link
Member

@naltatis naltatis commented Aug 27, 2022

Shows vehicle SoC limit for supported vehicles in the UI. This reduces confusion when the vehicle stops charging due to a vehicle-limit.

  • Vehicle limit is shown as a subtle gap in evcc soc bar.
  • Exact value is shown with a tooltip.
  • When the car is charging the light green area (amount that needs to be added) will stop at that gap if evccs soc limit is higher. In this case the evcc soc slider handle will also change color to grey. This indicates that it will not be the limiting factor. If the evcc slider is equal or less than the vehicle limit the handle is show green (as before).
  • Currently implement for Tesla API
  • Vehicle limit changes may show up in evcc with a delay. Standard caching times (similar to soc and range) apply.

Todos:
- [ ] implement more vehicle apis (we start with Tesla)

Vehicle SoC Limit as Gap
vehicle limit

Tooltip With Exact Value
tooltip

Active Charge (evcc limit > vehicle limit)
active charge

Active Charge (evcc limit == vehicle limit)
active charge equal

Active Charge (evcc limit < vehicle limit)
active charge lower

Dark Mode
dark model

@naltatis naltatis added enhancement New feature or request ux User experience/ interface labels Aug 27, 2022
@naltatis naltatis marked this pull request as draft August 27, 2022 16:32
@naltatis naltatis requested a review from andig August 27, 2022 16:33
api/api.go Outdated
@@ -172,6 +172,11 @@ type VehiclePosition interface {
Position() (float64, float64, error)
}

// VehicleTargetSoC returns the vehicles charge limit
type VehicleTargetSoC interface {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VehicleSoCLimiter

@premultiply premultiply added this to the Release 0.101 milestone Sep 1, 2022
core/loadpoint.go Outdated Show resolved Hide resolved
core/loadpoint.go Outdated Show resolved Hide resolved
@andig andig force-pushed the feature/vehicle_soc_indicator branch from 25aaf96 to 1eddb50 Compare September 2, 2022 09:06
@andig
Copy link
Member

andig commented Sep 2, 2022

Rebased

@naltatis naltatis marked this pull request as ready for review September 2, 2022 09:18
@naltatis naltatis merged commit 382eb67 into master Sep 2, 2022
@naltatis naltatis deleted the feature/vehicle_soc_indicator branch September 2, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience/ interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants