Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply configured phases for all modes #4195

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Apply configured phases for all modes #4195

merged 2 commits into from
Aug 23, 2022

Conversation

andig
Copy link
Member

@andig andig commented Aug 23, 2022

This PR:

  • always scales to configured phases, not only in PV mode
  • fixes phase scale timer reset when API called (it should not reset a running timer)
  • makes switching quicker by requesting loadpoint update after api call

@andig andig added the bug Something isn't working label Aug 23, 2022
@andig andig merged commit a22b445 into master Aug 23, 2022
@andig andig deleted the fix/1p3p-everywhere branch August 23, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naltatis naltatis naltatis approved these changes

@premultiply premultiply premultiply approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andig @naltatis @premultiply