Proper websocket (dis)connect when windows is hidden and restored #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ich kann nicht beurteilen ob das einen echten Vorteil bringt. |
|
@andig die Berücksichtigung von Page Visibility ist generell ne gute Idee. Ich kann mir gut vorstellen, dass das unser Problem auch löst oder mindert, konnte das aber natürlich nicht in der Fläche testen. Daher würd ich vorschlagen, dass wir das reinnehmen und schauen wie das Feedback ist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging the Page Visibility API to detect if the browser window is hidden (minimise, behind a window, app-switch). In this cases we perform a proper web socket disconnect and establish a fresh connection once its visible again.
I hope this fixes the issue with evcc not updating after longer inactivity #3504.
Another advantage: We save energy and bandwidth by not fetching data that nobody sees.