Heidelberg: Fix locking #4117
Merged
Heidelberg: Fix locking #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
reviewed
Aug 15, 2022
andig
reviewed
Aug 21, 2022
| @@ -131,6 +131,19 @@ func (wb *HeidelbergEC) Status() (api.ChargeStatus, error) { | |||
| case 9: | |||
| return api.StatusE, nil | |||
| case 10: | |||
| // ensure RemoteLock is disabled after wake-up | |||
| l, err := wb.conn.ReadInputRegisters(hecRegRemoteLock, 1) | |||
There was a problem hiding this comment.
Das brauchts doch nur beim Neustart und nicht ständig? Im Wakeup schaltest Du ja sonst immer frei- woher sollten da noch zusätzliche Locks kommen? Aber schadet vielleicht auch nichts...
There was a problem hiding this comment.
Geht ja nur darum dass Falls die WB den Unlock - aus welchem Grund auch immer - nicht wirklich mitbekommen hat, hier nochmal entsperrt wird.
|
Rein? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3596