Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadpoint: calculate minimum power taking phases into account #16274

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

andig
Copy link
Member

@andig andig commented Sep 22, 2024

This PR fixes an issue where minimum effective power did now take phase switching capability or active phases into account. This improves accuracy of loadpoint prioritisation.

/cc @VolkerK62

@andig andig added the bug Something isn't working label Sep 22, 2024
@andig
Copy link
Member Author

andig commented Sep 22, 2024

@premultiply wirf bitte nochmal einen Blick drauf- jetzt werden auch Fahrzeug, Messwerte und aktuelle Phasenlage mit einbezogen.

ACHTUNG EffectiveMinPower hängt damit dynamisch vom angeschlossenen Fahrzeug und ggf. auch aktuellen Messwerten ab. Ich bin nicht 100%ig sicher, ob das an allen stellen erwünscht ist (z.B. da wo es für SEMP verwendet wird). Evtl. müssen wir das doch nochmal etwas statischer denken?

@andig andig marked this pull request as draft September 22, 2024 19:23
@andig andig marked this pull request as ready for review September 26, 2024 06:00
@andig andig added the needs decision Unsure if we should really do this label Oct 7, 2024
@andig andig added the prio Priority label Oct 12, 2024
@andig andig merged commit d9a4152 into master Oct 13, 2024
7 checks passed
@andig andig deleted the fix/prioritizer branch October 13, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs decision Unsure if we should really do this prio Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants