Loadpoint: fix race condition accessing soc estimator (#16180) #16194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
changed the title
|
Klasse, auf den Fix bin ich gar nicht gekommen! |
|
Indeed. Nice catch @jennes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16180
It might not be ideal since a now soon-to-not-exist socEstimator may be updated, but the alternative would have been to have mutexes.
Since the bug seems to be rather esoteric, the risk of showing "old" information for a short period of time seems to be acceptable. It should be better than a hard crash in any case.
With that patch applied I couldn't provoke a crash anymore but since I don't fully understand the code paths of evcc (yet)…