Influxdb: add insecure option #16025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thierolm
reviewed
Sep 11, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I do see in the changes that it will be applied to influxdb2.0 (also or only?) - I would need the change for influxdb1.8 - just to make sure... |
naltatis
reviewed
Sep 23, 2024
server/influxdb.go
Outdated
| options := influxdb2.DefaultOptions() | ||
|
|
||
| tlsConfig := options.TLSConfig() | ||
| tlsConfig.InsecureSkipVerify = insecure |
There was a problem hiding this comment.
@andig hier ist noch irgendetwas krumm. Wenn InfluxDB konfiguriert crasht die Anwendung hier:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0xa0 pc=0x106872ae0]
goroutine 1 [running]:
github.com/evcc-io/evcc/server.NewInfluxClient({0x14002686240, 0x21}, {0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, ...)
/Users/michael/lab/evcc/server/influxdb.go:41 +0x240
github.com/evcc-io/evcc/cmd.configureInflux(0x109faa4f0)
/Users/michael/lab/evcc/cmd/setup.go:566 +0xe8
github.com/evcc-io/evcc/cmd.runRoot(0x109fa89a0, {0x1069e2590?, 0x7?, 0x1069d5565?})
/Users/michael/lab/evcc/cmd/root.go:187 +0x954
github.com/spf13/cobra.(*Command).execute(0x109fa89a0, {0x1400018c190, 0x2, 0x2})
/Users/michael/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:989 +0x81c
github.com/spf13/cobra.(*Command).ExecuteC(0x109fa89a0)
/Users/michael/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1117 +0x344
github.com/spf13/cobra.(*Command).Execute(...)
/Users/michael/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1041
github.com/evcc-io/evcc/cmd.Execute()
/Users/michael/lab/evcc/cmd/root.go:107 +0x24
main.main()
/Users/michael/lab/evcc/main.go:44 +0x38
exit status 2
|
Setting ist im Config UI für v1 und v2 hinzugefügt.
|
|
@naltatis Fehler sollte behoben sein. Hast Du einen Test? |
|
Manueller Test gegen eigenen Server war erfolgreich. |
naltatis
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16024