Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocpp: move get/set charging profile to connector #15660

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Ocpp: move get/set charging profile to connector #15660

merged 11 commits into from
Sep 5, 2024

Conversation

premultiply
Copy link
Member

@premultiply premultiply commented Aug 24, 2024 •
edited
Loading

No description provided.

@premultiply premultiply added the bug Something isn't working label Aug 24, 2024
@premultiply premultiply requested a review from andig August 24, 2024 21:01
@andig

This comment was marked as outdated.

Sign in to view
@premultiply
Copy link
Member Author

premultiply commented Aug 25, 2024 •
edited
Loading

Der Connector trägt u.a. automatisch die connectorId bei und liefert bei GetScheduleLimit nur noch das Limit zurück. Macht also jetzt die ganze Verarbeitung die vorher der Charger gemacht hat.

@andig

This comment was marked as outdated.

Sign in to view
@premultiply premultiply changed the title Ocpp: fix errors to chargepoint Ocpp: move get/set charging profile to connector Aug 25, 2024
@premultiply premultiply self-assigned this Aug 25, 2024
@premultiply premultiply removed the bug Something isn't working label Aug 25, 2024
andig
andig reviewed Aug 25, 2024
View reviewed changes
charger/ocpp/cs_core.go Outdated Show resolved Hide resolved
@andig andig added the infrastructure Basic functionality label Aug 25, 2024
@premultiply @andig
wip
7b28d5c 
Co-authored-by: andig <andi@evcc.io>
@premultiply premultiply marked this pull request as ready for review August 25, 2024 22:21
@andig andig marked this pull request as draft August 28, 2024 06:18
andig
andig reviewed Sep 1, 2024
View reviewed changes
charger/ocpp/cs_core.go Outdated Show resolved Hide resolved
andig
andig reviewed Sep 1, 2024
View reviewed changes
charger/ocpp/connector.go Outdated Show resolved Hide resolved
charger/ocpp/connector.go Outdated Show resolved Hide resolved
@premultiply premultiply assigned andig and unassigned premultiply Sep 2, 2024
@premultiply premultiply marked this pull request as ready for review September 2, 2024 21:33
@premultiply
Copy link
Member Author

Rein?

@andig
Copy link
Member

andig commented Sep 5, 2024

Nach den Timeouts- sonst muss ich da nochmal ran.

@andig andig merged commit 16107f9 into master Sep 5, 2024
6 checks passed
@andig andig deleted the feat/ocpp-move-getset-profile branch September 5, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig Awaiting requested review from andig

Assignees

@andig andig

Labels
infrastructure Basic functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@premultiply @andig