Site: remove root circuit configuration #14244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@premultiply könntest Du bitte nochmal bzgl. #14180 (comment) kommentieren? Das wird hiermit erzwungen. Ich bin aber unser, ob/wie wir das wirklich wollen? |
|
Ja, sehe das als notwendig und richtig an. |
|
Das ist klar- natürlich darf man keine Schleifen aus Circuits bauen. Aber warum dürfen keine Ladepunkte explizit am Root Circuit hängen? Das ist nicht so offensichtlich. Ich glaube wir brauchen eine Beschreibung, welcher Ladepunkt zu welchem Circuit "gezählt" wird? |
|
Diskussion in Doku PR evcc-io/docs#567 verschoben. |
andig
commented
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13802, fix #14180
Also:
/cc @premultiply