Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sungrow charger #13727

Merged
merged 5 commits into from
May 4, 2024
Merged

Fix Sungrow charger #13727

merged 5 commits into from
May 4, 2024

Conversation

premultiply
Copy link
Member

  • fix enabled()
  • fix enable(true)
  • protect phase switch as documentation states that it is not allowed to switch during state C

@premultiply premultiply added the devices Specific device support label May 3, 2024 — with GitHub Codespaces
Copy link
Contributor

@hameno hameno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

charger/sungrow.go Outdated Show resolved Hide resolved
charger/sungrow.go Outdated Show resolved Hide resolved
charger/sungrow.go Outdated Show resolved Hide resolved
charger/sungrow.go Outdated Show resolved Hide resolved
premultiply and others added 4 commits May 3, 2024 22:11
Co-authored-by: andig <andi@evcc.io>
Co-authored-by: andig <andi@evcc.io>
Co-authored-by: andig <andi@evcc.io>
@andig andig merged commit 4109b4b into master May 4, 2024
7 checks passed
@andig andig deleted the fix/sungrow-charger branch May 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants