use original name from source in error trace #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Aug 9, 2018
| @@ -278,7 +278,7 @@ it('throw with empty source map', function() { | |||
| 'throw new Error("test");' | |||
| ], [ | |||
| 'Error: test', | |||
| /^ at Object\.exports\.test \((?:.*[/\\])?.generated.js:1:34\)$/ | |||
| /^ at Object\.exports\.test \((?:.*[/\\])?\.generated.js:1:34\)$/ | |||
There was a problem hiding this comment.
there are various minor regex changes too
LinusU
reviewed
Aug 9, 2018
| @@ -278,7 +278,7 @@ it('throw with empty source map', function() { | |||
| 'throw new Error("test");' | |||
| ], [ | |||
| 'Error: test', | |||
| /^ at Object\.exports\.test \((?:.*[/\\])?.generated.js:1:34\)$/ | |||
| /^ at Object\.exports\.test \((?:.*[/\\])?\.generated.js:1:34\)$/ | |||
|
Looks great! Just waiting for the CI to turn green 👍 |
|
Published as v0.5.8 🚢 Thanks 🎉 |
|
Awesome - thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #205
The tests were failing due to not falling back to the original name when the source map position did not have a name.