Skip to content

Commit

Permalink
fix browser tests (broken by github)
Browse files Browse the repository at this point in the history
  • Loading branch information
evanw committed Dec 19, 2024
1 parent b804d31 commit 551c621
Show file tree
Hide file tree
Showing 3 changed files with 1,215 additions and 605 deletions.
14 changes: 13 additions & 1 deletion scripts/browser/browser-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,19 @@ console.log(`[http] listening on ${serverURL}`)
async function main() {
let allTestsPassed = true
try {
const browser = await require('puppeteer').launch()
const browser = await require('puppeteer').launch({
// This is here because since December 2024, GitHub changed something about
// their CI that causes this error:
//
// [FATAL:zygote_host_impl_linux.cc(128)] No usable sandbox! If you are running
// on Ubuntu 23.10+ or another Linux distro that has disabled unprivileged user
// namespaces with AppArmor, see https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md.
// Otherwise see https://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox_development.md
// for more information on developing with the (older) SUID sandbox. If you want
// to live dangerously and need an immediate workaround, you can try using
// --no-sandbox.
args: ['--no-sandbox'],
})

const page = await browser.newPage()
page.on('console', obj => {
Expand Down
Loading

0 comments on commit 551c621

Please sign in to comment.