Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: item swiper update #2416

Merged
merged 42 commits into from
Aug 29, 2024
Merged

feat: item swiper update #2416

merged 42 commits into from
Aug 29, 2024

Conversation

LeoniePeters
Copy link
Contributor

@LeoniePeters LeoniePeters commented Aug 8, 2024

  • Update Swiper package to v11 (as also done on #2404)
    • Update swiper options for all instances: StackedCardsSwiper, LandingIllustrationGroup
    • Add a11y module with custom messages
  • Adds thumbnails columns to the right of item swiper
  • Adds new ItemMediaSwiperThumbnail component
  • Extend MediaCardImage for reuse in ItemMediaSwiperThumbnail
  • Moves swiper pagination and navigation to thumbnails tab
  • Removes top padding around item swiper slides
  • Moves item video style from parent MediaCard to MediaVideoPlayer
  • Adds icons for 3d-bold, arrow-outline, image-bold, sound-bold, text-bold, video-bold

@LeoniePeters LeoniePeters added the work in progress Work in progress, not yet ready to be merged label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Preview deployment: https://pr-2416.portal-js.dev.eanadev.org/

@LeoniePeters LeoniePeters changed the title POC: item hero style update feat: item swiper update Aug 20, 2024
@LeoniePeters LeoniePeters removed the work in progress Work in progress, not yet ready to be merged label Aug 21, 2024
Copy link

sonarcloud bot commented Aug 29, 2024

@lbiedinger lbiedinger merged commit e2c939e into master Aug 29, 2024
16 of 17 checks passed
@lbiedinger lbiedinger deleted the feat/item-hero-style-update branch August 29, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants