-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: item swiper update #2416
Merged
Merged
feat: item swiper update #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LeoniePeters
commented
Aug 8, 2024
•
edited
Loading
edited
- Update Swiper package to v11 (as also done on #2404)
- Update swiper options for all instances: StackedCardsSwiper, LandingIllustrationGroup
- Add a11y module with custom messages
- Adds thumbnails columns to the right of item swiper
- Adds new ItemMediaSwiperThumbnail component
- Extend MediaCardImage for reuse in ItemMediaSwiperThumbnail
- Moves swiper pagination and navigation to thumbnails tab
- Removes top padding around item swiper slides
- Moves item video style from parent MediaCard to MediaVideoPlayer
- Adds icons for 3d-bold, arrow-outline, image-bold, sound-bold, text-bold, video-bold
…te-swiper-package
…te-swiper-package
LeoniePeters
added
the
work in progress
Work in progress, not yet ready to be merged
label
Aug 8, 2024
Preview deployment: https://pr-2416.portal-js.dev.eanadev.org/ |
LeoniePeters
removed
the
work in progress
Work in progress, not yet ready to be merged
label
Aug 21, 2024
lbiedinger
approved these changes
Aug 29, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.