-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings #222
Fix warnings #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be more portable to use a #define
and set it only if gcc or clang are in use.
An autoconf test plus a couple of ifdefs based on the result... I did it that way because I think that ancient compilers should silently ignore unsupported attributes. Do you have an example ancient compiler to test with? Then we can adjust to the resulting build with it. |
|
Now I see that there is one change that deserves a separate PR and review and it got included here (my mistake): dce2732#diff-74ecd06b7b5ba73ee97dbca326e44e3dddf6e8841bda2e073b06bdc4d8bd158d - this one is more serious than the rest from this PR and requires extra attention About the unused arguments warnings - eudev is Linux only and I have been thinking about a possible scenario where the |
We can restrict to gcc and clang since pcc/tcc/cparser should fail already for unrelated reasons and swcc is no more. I guess just documenting it should be fine. |
I have added a note in the build instructions about the modern C compiler requirement. @lu-zero Can you please provide build from source instructions for Gentoo? |
Sure, I double checked and we already depend on modern ( |
No description provided.