Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge suitable rules changes from systemd #220

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

bbonev
Copy link
Member

@bbonev bbonev commented Apr 5, 2022

Merge up to commit 5674b74c4f99e433fd8e7242e9f16f6ddfece94c

  • change @bindir@ to {{ROOTBINDIR}} in templates (better future tracking)
  • keep rules/50-udev-default.rules as plain instead of template
  • add
    60-autosuspend.rules
    60-fido-id.rules
    70-camera.rules
    70-memory.rules
    81-net-dhcp.rules

@bbonev bbonev linked an issue Apr 9, 2022 that may be closed by this pull request
Merge up to commit 5674b74c4f99e433fd8e7242e9f16f6ddfece94c

- change @bindir@ to {{ROOTBINDIR}} in templates (better future tracking)
- keep rules/50-udev-default.rules as plain instead of template
- add
  60-autosuspend.rules
  60-fido-id.rules
  70-camera.rules
  70-memory.rules
  81-net-dhcp.rules
Copy link
Member

@ArsenArsen ArsenArsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save for that one question, this seems fine. I'm not aware of anything even exporting SYSTEMD_READY even

@@ -3,6 +3,7 @@
SUBSYSTEM!="block", GOTO="btrfs_end"
ACTION=="remove", GOTO="btrfs_end"
ENV{ID_FS_TYPE}!="btrfs", GOTO="btrfs_end"
ENV{SYSTEMD_READY}=="0", GOTO="btrfs_end"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not happen at all in eudev; my thinking is that keeping it would make sync easier.

OTOH we can safely remove the line, I do not have strong opinion on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find it in sysd either, and I'm not aware of anything using it, which is why I ask

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, huh, that slipped by my grepping. I am guessing this option has no impact on boot with btrfs? namely, I'm not sure whether that check fails or passes with SYSTEMD_READY unset

@bbonev bbonev merged commit e3e483c into eudev-project:master Jun 6, 2022
@bbonev bbonev deleted the rules branch June 11, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto partitions missing from /dev/disk/by-label/
2 participants