-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge suitable rules changes from systemd #220
Conversation
Merge up to commit 5674b74c4f99e433fd8e7242e9f16f6ddfece94c - change @bindir@ to {{ROOTBINDIR}} in templates (better future tracking) - keep rules/50-udev-default.rules as plain instead of template - add 60-autosuspend.rules 60-fido-id.rules 70-camera.rules 70-memory.rules 81-net-dhcp.rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
save for that one question, this seems fine. I'm not aware of anything even exporting SYSTEMD_READY even
@@ -3,6 +3,7 @@ | |||
SUBSYSTEM!="block", GOTO="btrfs_end" | |||
ACTION=="remove", GOTO="btrfs_end" | |||
ENV{ID_FS_TYPE}!="btrfs", GOTO="btrfs_end" | |||
ENV{SYSTEMD_READY}=="0", GOTO="btrfs_end" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not happen at all in eudev
; my thinking is that keeping it would make sync easier.
OTOH we can safely remove the line, I do not have strong opinion on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find it in sysd either, and I'm not aware of anything using it, which is why I ask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, huh, that slipped by my grepping. I am guessing this option has no impact on boot with btrfs? namely, I'm not sure whether that check fails or passes with SYSTEMD_READY unset
Merge up to commit 5674b74c4f99e433fd8e7242e9f16f6ddfece94c
60-autosuspend.rules
60-fido-id.rules
70-camera.rules
70-memory.rules
81-net-dhcp.rules