Typos/editorial comments #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skounis
reviewed
Jun 27, 2024
|
|
||
| - both the body providing EUDI Wallets and the ng PID Providers have | ||
| - both the body providing EUDI Wallets and the PID Providers have |
There was a problem hiding this comment.
I saw this fix in another PR so let's be careful when we merge so we avoid any conflicts
skounis
reviewed
Jun 27, 2024
docs/arf.md
Outdated
| @@ -1364,7 +1364,7 @@ trust in the EUDI Wallet ecosystem: | |||
| or mDL attestation type. | |||
|
|
|||
| - Relying Parties may try to request attributes from a Wallet | |||
| Instance for which they have lawful grounds. | |||
| Instance for which they have no lawful grounds. | |||
There was a problem hiding this comment.
This is also part of another one PR, so let's pay attention when we merge
skounis
approved these changes
Jun 27, 2024
|
thank you @pinamiranda |
digeorgi
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typos:
Line 221: "display" -> "present"
Line 459 - 461: “The requirements […] are indented” → intended
Line 573: “enable the EUDI Wallet to work smooth” → smoothly
Line 760: why is the acronym for 'PID Issuance Interface' PPI instead of PII ?
Line 920: “the ng PID Providers”
Line 1272: “As a of the registration' --> "As a consequence of the registration"
Lines 1366-1367: “ Relying Parties may try to request attributes from a Wallet Instance for which they have lawful grounds.” → “no lawful ground” ?
Line 1478: “to the Attestation Provide” -> Provider