Emit absolute approval amounts with approval events

etoroxlabs · Jan 27, 2019 · bbc935f · bbc935f
1 parent 41bb56b
commit bbc935f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/contracts/token/ERC20/ExternalERC20.sol b/contracts/token/ERC20/ExternalERC20.sol
@@ -163,7 +163,7 @@ contract ExternalERC20 is IERC20 {
             _externalERC20Storage.allowed(from, originSender).sub(value)
         );
         _transfer(from, to, value);
-        emit Approval(from, originSender, value);
+        emit Approval(from, originSender, _externalERC20Storage.allowed(from, originSender));
     }
 
     /**
@@ -266,6 +266,6 @@ contract ExternalERC20 is IERC20 {
                 _externalERC20Storage.allowed(account, burner).sub(value)
             );
         _burn(account, value);
-        emit Approval(account, burner, value);
+        emit Approval(account, burner, _externalERC20Storage.allowed(account, burner));
     }
 }
diff --git a/test/token/ERC20/behaviors/ERC20.public.behavior.js b/test/token/ERC20/behaviors/ERC20.public.behavior.js
@@ -206,7 +206,7 @@ function shouldBehaveLikeERC20PublicAPI (owner, recipient, anotherAccount) {
               expectEvent.inLogs(events, 'Approval', {
                 owner: owner,
                 spender: spender,
-                value: amount
+                value: 0
               });
             });
           });

diff --git a/test/token/ERC20/behaviors/ERC20Burnable.behavior.js b/test/token/ERC20/behaviors/ERC20Burnable.behavior.js
@@ -89,7 +89,7 @@ function shouldBehaveLikeERC20Burnable (owner, initialBalance, [burner]) {
           expectEvent.inLogs(this.logs, 'Approval', {
             owner: owner,
             spender: burner,
-            value: amount
+            value: originalAllowance - amount
           });
         });
       }