Fixed bad TagSet initializer at OctetString encoder #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 85.8% 85.77% -0.04%
==========================================
Files 29 29
Lines 3973 3985 +12
==========================================
+ Hits 3409 3418 +9
- Misses 564 567 +3
Continue to review full report at Codecov.
|
|
@etingof thank you so much for the quick turnaround time on this! We noticed the issue this morning, and I'd be happy to assist in any way (testing? review?) if it would help. Thanks for your maintenance of this project 😃 |
|
@ryanwilsonperkin I hope to make a release tonight. Just wanted to add some more tests on this. Thank you! ;-) |
...at OctetString encoder
... at BitString encoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.4.1 regression