Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry install micc fails #12

Closed
etijskens opened this issue Nov 8, 2019 · 3 comments
Closed

poetry install micc fails #12

etijskens opened this issue Nov 8, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@etijskens
Copy link
Owner

etijskens commented Nov 8, 2019

I discovered that
poetry install fails on micc. filed bug report #1492. The issue is there
for both poetry v0.12.17 and v1.0.0b1.

nobody reacted to the issue - gotta do it myself...
or abandon poetry...
which may be the right thing to do in view of the many open issues.

on the other hand, poetry has a very simple mechanism for custom builds, see issue 1351 and investing time in setuptools is perhaps wasted.

fixing the bug in poetry install micc is meaningless if it is not accepted by poetry. maybe I better look for a workaround, like archiving the templates directory and unarchiving it as an custom install step.

@etijskens
Copy link
Owner Author

But then poetry still lacks an editable install...

@etijskens etijskens added the bug Something isn't working label Nov 8, 2019
@etijskens
Copy link
Owner Author

etijskens commented Nov 8, 2019

We could use shutil.make_archive and shutil.unpack_archive for the workaround.
Is there a post-install hook in poetry?
There isn't. Moreover, it is unlikely to come ... See Support for custom commands and functions
I don't want to go down the road of manual post-install scripts
Probably got to stick to setuptools at least for some time.

@etijskens
Copy link
Owner Author

etijskens commented Nov 11, 2019

The reason why poetry install fails on installing micc, is that poetry considered the templates directory as a Python package instead of a data directory, because it contains .py files. We can avoid this by replacing the py extension in these filenames with a cookiecutter variable {{cookiecutter.py}} and set the variable to "py".
Works as a charm! now poetry install no longer fails.

etijskens added a commit that referenced this issue Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant