Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflections on Poetry #15

Closed
etijskens opened this issue Nov 8, 2019 · 6 comments
Closed

Reflections on Poetry #15

etijskens opened this issue Nov 8, 2019 · 6 comments
Labels
question Further information is requested

Comments

@etijskens
Copy link
Owner

poetry install micc fails see issue 12 and nobody reacts to my poetry issue 1492
There are also many open issues and pull requests, as well as criticism

I feel there is little chance that if I succeed in finding and resolving the bug, the solution will be absorbed in poetry any time soon, so I'd rather go for a workaround.

On the other hand, poetry has a very simple mechanism for custom builds, see issue 1351 and investing time in setuptools is perhaps wasted.

@etijskens etijskens added the question Further information is requested label Nov 8, 2019
@etijskens
Copy link
Owner Author

There isn't a post-install hook. Moreover, it is unlikely to come ... See Support for custom commands and functions
The conclusion is that I will put the adoption of poetry in the fridge until it has matured and clearly shows fitness for our purposes.

@etijskens
Copy link
Owner Author

now that #12 if fixed, I decided to give poetry another chance.

  • poetry install works
  • poetry publish does too!
    let's see if we can publish projects with binary extensions...

@etijskens
Copy link
Owner Author

poetry doesn't play well with poetry
pip install micc installed in /Library/Frameworks/Python.framework/Versions/3.8/bin/micc while Conda environment test-micc was activated.
have to refrain from Conda then.

@etijskens
Copy link
Owner Author

etijskens commented Nov 13, 2019

I picked up this link from PYCODER'S WEEKLY. It describes a python development environment and kind of a workflow based on pyenv, poetry and pipx. The author, Jacob Kaplan-Moss is a co-creator of Django, so I expect this to be really well functioning.

@etijskens
Copy link
Owner Author

etijskens commented Nov 14, 2019

Poetry install is not working well:

cd /path/to/et-micc
poetry install
micc -p ../ws-micc/foo create
...
AttributeError: module 'et_micc' has no attribute 'cli'

can be solved by adding the line
from et_micc import cli
to /path/to/et-micc/.venv/bin/micc
Note that this is automatically a development install: the venv automatically links into the package directory which solves another problem we had with poetry!

@etijskens
Copy link
Owner Author

now that micc-build is separated from micc, and binary extensions are always built locally, there is no need for publishing binary extensions. poetry 1.0.0b4 does very well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant