Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed logger to name for Logot.capturing() #95

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Renamed logger to name for Logot.capturing() #95

merged 3 commits into from
Feb 9, 2024

Conversation

etianen
Copy link
Owner

@etianen etianen commented Feb 9, 2024

This will allow parity when matching on LogRecord.name (see #80). It's also more applicable to terms used in 3rd-party logging frameworks (e.g. loguru).

@etianen etianen added the breaking change Breaking change to the public API label Feb 9, 2024
@etianen etianen merged commit afd581a into main Feb 9, 2024
16 checks passed
@etianen etianen deleted the dh/breaking branch February 9, 2024 23:32
@etianen etianen changed the title Renaming logger to name for Logot.capturing() Renamed logger to name for Logot.capturing() Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change to the public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant