Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add config from fideslib #626

Merged
merged 5 commits into from
Jun 13, 2022
Merged

Add config from fideslib #626

merged 5 commits into from
Jun 13, 2022

Conversation

sanders41
Copy link
Contributor

Purpose

Implement config from fideslib.

Changes

  • Replace FidesSettings with FidesSettings from fideslib
  • Inherit DatabaseSettings from fideslib and extend with fidesops specific items
  • Inherit SecuritySettings from fideslib and extend with fidesops specific items
  • Replace load_toml with load_toml from fideslib
  • Replace load_file with load_file from fideslib
  • Replace get_config with get_config from fideslib

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@sanders41 sanders41 changed the title Fideslib config Add config from fideslib Jun 9, 2022
@sanders41 sanders41 marked this pull request as ready for review June 10, 2022 13:30
@sanders41
Copy link
Contributor Author

There are currently 3 tests set to xfail. There are open PRs in fideslib, ,20 and 22, that will make the tests pass. This PR should not be merged until the fideslib bug fixes are merged and released.

@sanders41
Copy link
Contributor Author

The updates from fideslib are in and xfails are removed from tests so everything is ready now.

@TheAndrewJackson TheAndrewJackson merged commit 84b1e95 into main Jun 13, 2022
@TheAndrewJackson TheAndrewJackson deleted the fideslib-config branch June 13, 2022 17:44
sanders41 added a commit that referenced this pull request Sep 22, 2022
* Add fideslib config

* Bump fideslib from 2.0.2 to 2.0.3

* Fix mypy error

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants